Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh manual pypi publish instructions #5252

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Apr 17, 2023

🚀 Pull Request

Description

This PR refreshes the instructions to manually build and publish the scitools-iris sdist and binary wheels to PyPI.

image


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3ca669d) 89.31% compared to head (f15bdd7) 89.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5252      +/-   ##
==========================================
- Coverage   89.31%   89.31%   -0.01%     
==========================================
  Files          88       88              
  Lines       22281    22279       -2     
  Branches     4881     4881              
==========================================
- Hits        19900    19898       -2     
  Misses       1635     1635              
  Partials      746      746              

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bjlittle
Copy link
Member Author

Note that, we can also extend this process by adding a check-manifest step to ensure that the PyPI assets contain the payload that we expect and require. We can also automate this process as part of the GHA workflow... PRs inbound for that later.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these changes and they work.

@trexfeathers trexfeathers merged commit 0d7e3cb into SciTools:main Apr 17, 2023
@bjlittle bjlittle deleted the update-manual-pypi branch April 18, 2023 15:19
tkknight added a commit to tkknight/iris that referenced this pull request Apr 18, 2023
* upstream/main: (29 commits)
  review actions
  update .git-blame-ignore-revs
  adopt codespell
  Adopt sphinx design (SciTools#5127)
  Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253)
  refresh manual pypi publish instructions (SciTools#5252)
  Updated environment lockfiles (SciTools#5250)
  removed bugfix section
  Make bm_runner location agnostic and include debugging. (SciTools#5247)
  Restore latest Whats New files.
  SciTools#5220 typo github.repository_owner. (SciTools#5248)
  Whats new updates for v3.5.0rc0. (SciTools#5246)
  libnetcdf <4.9 pin (SciTools#5242)
  update cf standard units (SciTools#5244)
  Updated environment lockfiles (SciTools#5211)
  update ci locks location (SciTools#5228)
  Fixes to _discontiguity_in_bounds (attempt 2) (SciTools#4975)
  Finalises Lazy Data documentation (SciTools#5137)
  Modernize and simplify iris.analysis._Groupby (SciTools#5015)
  clarity on whatsnew entry contributors (SciTools#5240)
  ...
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
* upstream/main: (61 commits)
  Updated environment lockfiles (SciTools#5270)
  Drop python3.8 support (SciTools#5269)
  build wheel from sdist, not src (SciTools#5266)
  Lazy netcdf saves (SciTools#5191)
  move setup.cfg to pyproject.toml (SciTools#5262)
  Support Python 3.11 (SciTools#5226)
  Remove Resolve test workaround (SciTools#5267)
  add missing whatsnew entry (SciTools#5265)
  make help (SciTools#5258)
  automate pypi manifest checking (SciTools#5259)
  drop sphinxcontrib-napoleon (SciTools#5263)
  add missing test result data (SciTools#5260)
  fix indentation and remove ref to ssstack (SciTools#5256)
  review actions
  update .git-blame-ignore-revs
  adopt codespell
  Adopt sphinx design (SciTools#5127)
  Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253)
  refresh manual pypi publish instructions (SciTools#5252)
  Updated environment lockfiles (SciTools#5250)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants