Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bm_runner location agnostic and include debugging. #5247

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Something I missed when creating the benchmark runner. Because of this, the overnight benchmarks have been exiting silently since last week!


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e2cfd4) 89.31% compared to head (70ad715) 89.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5247   +/-   ##
=======================================
  Coverage   89.31%   89.31%           
=======================================
  Files          88       88           
  Lines       22279    22279           
  Branches     4881     4881           
=======================================
  Hits        19898    19898           
  Misses       1635     1635           
  Partials      746      746           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @trexfeathers !

@lbdreyer lbdreyer merged commit cbfb0cc into SciTools:main Apr 14, 2023
@trexfeathers
Copy link
Contributor Author

Many thanks @lbdreyer

tkknight added a commit to tkknight/iris that referenced this pull request Apr 18, 2023
* upstream/main: (29 commits)
  review actions
  update .git-blame-ignore-revs
  adopt codespell
  Adopt sphinx design (SciTools#5127)
  Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253)
  refresh manual pypi publish instructions (SciTools#5252)
  Updated environment lockfiles (SciTools#5250)
  removed bugfix section
  Make bm_runner location agnostic and include debugging. (SciTools#5247)
  Restore latest Whats New files.
  SciTools#5220 typo github.repository_owner. (SciTools#5248)
  Whats new updates for v3.5.0rc0. (SciTools#5246)
  libnetcdf <4.9 pin (SciTools#5242)
  update cf standard units (SciTools#5244)
  Updated environment lockfiles (SciTools#5211)
  update ci locks location (SciTools#5228)
  Fixes to _discontiguity_in_bounds (attempt 2) (SciTools#4975)
  Finalises Lazy Data documentation (SciTools#5137)
  Modernize and simplify iris.analysis._Groupby (SciTools#5015)
  clarity on whatsnew entry contributors (SciTools#5240)
  ...
@trexfeathers trexfeathers deleted the bm_runner_dir branch May 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants