Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SnoopPrecompile and fix _unwrap_val #94

Closed

Conversation

oscardssmith
Copy link
Contributor

Adding precompile here should save time in the OrdinaryDiffEq precompile.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #94 (0222103) into master (54c7da2) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 0222103 differs from pull request most recent head 1b26f69. Consider uploading reports for the commit 1b26f69 to get more accurate results

@@          Coverage Diff           @@
##           master     #94   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       9    +1     
  Lines         459     461    +2     
======================================
- Misses        459     461    +2     
Impacted Files Coverage Δ
src/NonlinearSolve.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oscardssmith oscardssmith changed the title add SnoopPrecompile and fix _unwrap_val add SnoopPrecompile and fix _unwrap_val Nov 4, 2022
@oscardssmith
Copy link
Contributor Author

@YingboMa can we merge this? CI isn't passing but it wasn't before this PR either and this PR makes it so precompilation at least works.

@ChrisRackauckas
Copy link
Member

No merging here until #88

@oscardssmith oscardssmith deleted the add-snoopprecompie-and-fix-bug branch November 24, 2022 12:43
avik-pal pushed a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants