-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle downstream usage issues #88
Conversation
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
===========================================
+ Coverage 0.00% 37.22% +37.22%
===========================================
Files 8 5 -3
Lines 459 231 -228
===========================================
+ Hits 0 86 +86
+ Misses 459 145 -314
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The tests here are not running at all. The code coverage has been zero for more than half a year https://app.codecov.io/gh/SciML/NonlinearSolve.jl. The reason is that you only run the tests for NonlinearSolve.jl/test/runtests.jl Line 10 in 22ed463
GROUP never has any of those values NonlinearSolve.jl/.github/workflows/CI.yml Lines 15 to 16 in 22ed463
|
It seems this library wasn't properly tested...
202f67f
to
98791e9
Compare
Finally. |
Can the downstream failure safely be ignored? |
Yes, this is getting a v1.0 release, and MTK is moving to SimpleNonlinerSolve.jl. It took awhile because this library had to be split to get the dependencies correct, which is a very breaking change. It also unifies the arguments (abstol instead of tol), so it's a very breaking update. Basically, it's finally updated from being an overlooked intern project to a full compliant piece of SciML, with all of the breakage required to make it conform to the rules of the interface. The update should be relatively sane though since most things would actually just move to SimpleNonlinearSolve.jl: the "bigger" Newton here is really just for big systems which isn't used all that much downstream. |
Automatic JuliaFormatter.jl run
It seems this library wasn't properly tested...