Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different termination norm for NLLS #399

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Mar 31, 2024

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.80%. Comparing base (e231d64) to head (fb0f1eb).

Files Patch % Lines
src/internal/tracing.jl 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   86.75%   86.80%   +0.04%     
==========================================
  Files          46       46              
  Lines        2809     2827      +18     
==========================================
+ Hits         2437     2454      +17     
- Misses        372      373       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title [WIP] Use a different termination norm for NLLS Use a different termination norm for NLLS Mar 31, 2024
@avik-pal avik-pal force-pushed the ap/nlls_term branch 10 times, most recently from 195042c to 2a7b59b Compare March 31, 2024 20:08
@ChrisRackauckas ChrisRackauckas merged commit d8d9eea into master Apr 1, 2024
15 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/nlls_term branch April 1, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants