-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching for solvers without init #382
Conversation
c756d35
to
a67d6ed
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 88.11% 87.95% -0.16%
==========================================
Files 45 46 +1
Lines 2675 2690 +15
==========================================
+ Hits 2357 2366 +9
- Misses 318 324 +6 ☔ View full report in Codecov by Sentry. |
I will do a little bit of type piracy for SimpleNonlinearSolve to avoid having to copy over this code there. Also because caching interface comes into play when NonlinearSolve compatibility is needed |
a67d6ed
to
e37b70a
Compare
prob | ||
alg | ||
args | ||
kwargs::Any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this effect type inference? I don't see why this wouldn't be concrete as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed because cache.kwargs = merge(cache.kwargs, kwargs)
can change the type in reinit
That seems reasonable. |
This is needed because we want to write generic code with
init
andsolve!
without having to query every solver to check if it supports caching.