-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Use NonlinearSolve for all root finding needs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ideally needs SciML/NonlinearSolve.jl#382 |
TODO
|
avik-pal
force-pushed
the
ap/nonlinearsolve
branch
from
February 20, 2024 18:43
dc75d49
to
48736d0
Compare
avik-pal
changed the title
Use NonlinearSolve for all root finding needs
[Breaking] Use NonlinearSolve for all root finding needs
Feb 20, 2024
ChrisRackauckas
approved these changes
Feb 21, 2024
avik-pal
force-pushed
the
ap/nonlinearsolve
branch
8 times, most recently
from
February 21, 2024 19:15
8ef7b1e
to
9f705b0
Compare
avik-pal
force-pushed
the
ap/nonlinearsolve
branch
from
February 21, 2024 19:39
9f705b0
to
eb73790
Compare
Tests pass, I am bumping the project version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 downside is that the API for
ManifoldProjection
will become a bit more verbose, because we are no longer solving a singular root-finding problem (which NLsolve does withpinv
IIRC). Instead for in place problems we have to specifyresid_prototype
, no such restriction for OOPg
(yes those are supported now!!).If the internal solver fails, we terminate the solution process, unlike before where we just keep going.
Initial Benchmarks
For the first test in
manifold_tests.jl