Standardize the Extension Algorithms #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 88.04% 87.47% -0.57%
==========================================
Files 27 28 +1
Lines 2174 2172 -2
==========================================
- Hits 1914 1900 -14
- Misses 260 272 +12 ☔ View full report in Codecov by Sentry. |
avik-pal
force-pushed
the
ap/fastlm_jac
branch
from
2779c92 to
c79d228
Compare
avik-pal
force-pushed
the
ap/fastlm_jac
branch
from
c79d228 to
f2edda0
Compare
avik-pal
commented
Dec 24, 2023
Comment on lines
-22
to
-26
| function (u) | ||
| du = similar(u) | ||
| prob.f(du, u, prob.p) | ||
| return du | ||
| end |
There was a problem hiding this comment.
This shouldn't originate in the first place.
There was a problem hiding this comment.
Yeah, the scalar case root finding doesn't need this
avik-pal
force-pushed
the
ap/fastlm_jac
branch
from
e987f91 to
e3ad1d1
Compare
avik-pal
force-pushed
the
ap/fastlm_jac
branch
2 times, most recently
from
d3131c9 to
fd08605
Compare
avik-pal
force-pushed
the
ap/fastlm_jac
branch
from
fd08605 to
2d19f54
Compare
ErikQQY
reviewed
Dec 25, 2023
avik-pal
commented
Dec 25, 2023
| @@ -9,7 +9,7 @@ isinplace(JᵀJ::KrylovJᵀJ) = isinplace(JᵀJ.Jᵀ) | |||
|
|
|||
| # Select if we are going to use sparse differentiation or not | |||
| sparsity_detection_alg(_, _) = NoSparsityDetection() | |||
| function sparsity_detection_alg(f, ad::AbstractSparseADType) | |||
| function sparsity_detection_alg(f::NonlinearFunction, ad::AbstractSparseADType) | |||
There was a problem hiding this comment.
Does this need to specialize?
There was a problem hiding this comment.
safety measure, we are using f.sparsity and stuff in there.
ChrisRackauckas
approved these changes
Dec 25, 2023
|
Are the 23 test problem failures known? |
|
I presume that's what was fixed in the problem library, so it should have passed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
jacobian!!in FastLM