Skip to content

Commit

Permalink
Incorrect depwarn call
Browse files Browse the repository at this point in the history
  • Loading branch information
avik-pal committed Dec 24, 2023
1 parent f2edda0 commit fd08605
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NonlinearSolve"
uuid = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
authors = ["SciML"]
version = "3.3.1"
version = "3.4.0"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
13 changes: 7 additions & 6 deletions src/extension_algs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function CMINPACK(; show_trace = missing, tracing = missing, method::Symbol = :a
Base.depwarn("`show_trace` for CMINPACK has been deprecated and will be removed \

Check warning on line 141 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L141

Added line #L141 was not covered by tests
in v4. Use the `show_trace` keyword argument via the logging API \
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ \
instead.")
instead.", :CMINPACK)
else
show_trace = false
end
Expand All @@ -150,7 +150,7 @@ function CMINPACK(; show_trace = missing, tracing = missing, method::Symbol = :a
Base.depwarn("`tracing` for CMINPACK has been deprecated and will be removed \

Check warning on line 150 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L150

Added line #L150 was not covered by tests
in v4. Use the `store_trace` keyword argument via the logging API \
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ \
instead.")
instead.", :CMINPACK)
else
tracing = false
end
Expand Down Expand Up @@ -219,7 +219,7 @@ function NLsolveJL(; method = :trust_region, autodiff = :central, store_trace =
Base.depwarn("`show_trace` for NLsolveJL has been deprecated and will be removed \

Check warning on line 219 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L218-L219

Added lines #L218 - L219 were not covered by tests
in v4. Use the `show_trace` keyword argument via the logging API \
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ \
instead.")
instead.", :NLsolveJL)
else
show_trace = false

Check warning on line 224 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L224

Added line #L224 was not covered by tests
end
Expand All @@ -228,7 +228,7 @@ function NLsolveJL(; method = :trust_region, autodiff = :central, store_trace =
Base.depwarn("`store_trace` for NLsolveJL has been deprecated and will be removed \

Check warning on line 228 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L227-L228

Added lines #L227 - L228 were not covered by tests
in v4. Use the `store_trace` keyword argument via the logging API \
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ \
instead.")
instead.", :NLsolveJL)
else
store_trace = false

Check warning on line 233 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L233

Added line #L233 was not covered by tests
end
Expand All @@ -237,7 +237,8 @@ function NLsolveJL(; method = :trust_region, autodiff = :central, store_trace =
Base.depwarn("`extended_trace` for NLsolveJL has been deprecated and will be \

Check warning on line 237 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L236-L237

Added lines #L236 - L237 were not covered by tests
removed in v4. Use the `trace_level = TraceAll()` keyword argument \
via the logging API \
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ instead.")
https://docs.sciml.ai/NonlinearSolve/stable/basics/Logging/ instead.",
:NLsolveJL)
else
extended_trace = false

Check warning on line 243 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L243

Added line #L243 was not covered by tests
end
Expand Down Expand Up @@ -388,5 +389,5 @@ function SIAMFANLEquationsJL(; method = :newton, delta = 1e-3, linsolve = nothin
if Base.get_extension(@__MODULE__, :NonlinearSolveSIAMFANLEquationsExt) === nothing
error("SIAMFANLEquationsJL requires SIAMFANLEquations.jl to be loaded")
end
return SIAMFANLEquationsJL(method, show_trace, delta, linsolve)
return SIAMFANLEquationsJL(method, delta, linsolve)

Check warning on line 392 in src/extension_algs.jl

View check run for this annotation

Codecov / codecov/patch

src/extension_algs.jl#L392

Added line #L392 was not covered by tests
end

0 comments on commit fd08605

Please sign in to comment.