Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Allocation for Inexact Jacobian #266

Merged
merged 5 commits into from
Nov 1, 2023
+26 −9
Merged

Removing Allocation for Inexact Jacobian #266

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
413f40b
don't allocate for inexact jacobian. just modifiy J
yonatanwesen Oct 27, 2023
7efded5
address comments
yonatanwesen Oct 27, 2023
467009c
actually avoid making allocations for inexact jacobian
yonatanwesen Oct 28, 2023
7390f71
fix project.toml?
yonatanwesen Oct 31, 2023
abaf747
address comments and add compat for FastBroadcast
yonatanwesen Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/pseudotransient.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,17 @@ end
function perform_step!(cache::PseudoTransientCache{true})
@unpack u, u_prev, fu1, f, p, alg, J, linsolve, du, alpha, tc_storage = cache
jacobian!!(J, cache)
J_new = J - (1 / alpha) * I
if J isa SciMLBase.AbstractSciMLOperator
J = J - (1 / alpha) * I
else
J .= J - (1 / alpha) * I
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still allocates. Use the same flow as https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/derivative_utils.jl#L494-L503

end
#J_new = J - (1 / alpha) * I
yonatanwesen marked this conversation as resolved.
Show resolved Hide resolved

termination_condition = cache.termination_condition(tc_storage)

# u = u - J \ fu
linres = dolinsolve(alg.precs, linsolve; A = J_new, b = _vec(fu1), linu = _vec(du),
linres = dolinsolve(alg.precs, linsolve; A = J, b = _vec(fu1), linu = _vec(du),
p, reltol = cache.abstol)
cache.linsolve = linres.cache
@. u = u - du
Expand Down Expand Up @@ -147,11 +152,13 @@ function perform_step!(cache::PseudoTransientCache{false})
termination_condition = cache.termination_condition(tc_storage)

cache.J = jacobian!!(cache.J, cache)

cache.J = cache.J - (1 / alpha) * I
# u = u - J \ fu
if linsolve === nothing
cache.du = fu1 / (cache.J - (1 / alpha) * I)
cache.du = fu1 / (cache.J)
yonatanwesen marked this conversation as resolved.
Show resolved Hide resolved
else
linres = dolinsolve(alg.precs, linsolve; A = cache.J - (1 / alpha) * I,
linres = dolinsolve(alg.precs, linsolve; A = cache.J,
b = _vec(fu1),
yonatanwesen marked this conversation as resolved.
Show resolved Hide resolved
linu = _vec(cache.du), p, reltol = cache.abstol)
cache.linsolve = linres.cache
Expand Down
Loading