Removing Allocation for Inexact Jacobian #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
===========================================
- Coverage 93.04% 40.40% -52.64%
===========================================
Files 19 19
Lines 1796 1767 -29
===========================================
- Hits 1671 714 -957
- Misses 125 1053 +928
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
avik-pal
requested changes
Oct 27, 2023
src/pseudotransient.jl
Outdated
| if J isa SciMLBase.AbstractSciMLOperator | ||
| J = J - (1 / alpha) * I | ||
| else | ||
| J .= J - (1 / alpha) * I |
There was a problem hiding this comment.
This still allocates. Use the same flow as https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/derivative_utils.jl#L494-L503
avik-pal
requested changes
Oct 31, 2023
ChrisRackauckas
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make sure that we don't allocate memory when computing the inexact Jacobian for PT methods. Instead, we just overwrite the jacobian that is already allocated. @avik-pal @ChrisRackauckas