Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile Time explodes with v2.0.0 #223

Closed
waldie11 opened this issue Oct 2, 2023 · 5 comments
Closed

Precompile Time explodes with v2.0.0 #223

waldie11 opened this issue Oct 2, 2023 · 5 comments

Comments

@waldie11
Copy link

waldie11 commented Oct 2, 2023

I am using NonlinearSolve as a dependency from OrdinaryDiffEq.jl
Iam used to see OrdinaryDiffEq being a heavy dependency in the precompile phase. Pulling in NonlinearSolve on v2.0.0 is however skyrocketing precompile time - increasing also precompile time for packages depending on it.

Starting from this setup from a plain .julia environment, precompile is finished within 4min on my machine. After dropping the restriction on <2.0.0 Iam giving up after 5min only seeing NonlinearSolve and not even starting with OrdinaryDiffEq. I have seen it finish already, but I didnt time it then (and am not going to do it again) and think its in the region of 30min.

name = "short_test"
uuid = "ac54827c-5042-4dc0-8a8e-9aaad1679992"

[deps]
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"

[compat]
NonlinearSolve = "<2.0.0"

[weakdeps]
NonlinearSolve = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
  [8913a72c]  NonlinearSolve v1.10.1  v2.0.0
Precompiling project...
  Progress [>                                        ]  0/3
  ◓ NonlinearSolve
@ErikQQY
Copy link
Member

ErikQQY commented Oct 2, 2023

Same here, I tested on a server, plain environment, precompiled BoundaryValueDiffEq version 5.0.0(which uses NonlinearSolve version 2.0.0), took about 20 mins to only finish the NonlinearSolve precompiling

simonbyrne added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
@simonbyrne
Copy link

On my machine (Julia 1.9.3 on an M2 mac), precompilation of NonlinearSolve.jl goes from 14 seconds to 273 seconds.

simonbyrne added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
@simonbyrne
Copy link

I bisected it to 78beabe

bors bot added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
@avik-pal
Copy link
Member

avik-pal commented Oct 2, 2023

Removing the @compile_workload brings down the precompile time from 690s to 29s locally 😓

simonbyrne added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
bors bot added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
bors bot added a commit to CliMA/ClimaCore.jl that referenced this issue Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
@ChrisRackauckas
Copy link
Member

This is solved. It's a v1.9 bug, so we'll only precompile on v1.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants