Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound NonlinearSolve.jl test compat #1482

Closed
wants to merge 1 commit into from
Closed

Conversation

simonbyrne
Copy link
Member

@simonbyrne simonbyrne commented Oct 2, 2023

Caused blow up in compilation time SciML/NonlinearSolve.jl#223

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@charleskawczynski
Copy link
Member

Do we need to add NonLinearSolve.jl as a dependency to add the compat entry?

@simonbyrne
Copy link
Member Author

Do we need to add NonLinearSolve.jl as a dependency to add the compat entry?

Why, yes we probably do.

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
1482: Bound NonlinearSolve.jl test compat r=simonbyrne a=simonbyrne

Caused blow up in compilation time SciML/NonlinearSolve.jl#223



Co-authored-by: Simon Byrne <[email protected]>
@simonbyrne
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Canceled.

@simonbyrne
Copy link
Member Author

Fixed upstream

@simonbyrne simonbyrne closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants