Rename KS Rank to RSA and fix documentation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add raw string annotation
KSRank is stochastic and slight variations in the outcome measures are possible. New tests check whether parameters are correctly identified as sensitive.
Make tests less sensitive to random variability in the sensitivity criterion. Also indicate the random variability influence in the documentation.
Use JuliaFormatter
Add more detailed explanation of f(Y) function signature, and fix typos in math.
Add description of returned KSRankResult struct
Add @doc signature
Change math $ into ``
Use correct link
Renamed KS_Rank to RSA in line with how the method is known in literature.
fix compatibility issues with SortingAlgorithms.jl
Bump lower bound of StatsBase to 0.33.7
Modify default argument of n_dummy_parameters to 10
|
This should also fix #13 |
|
And fixes the downgrade test fail by bumping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
The method I previously defined as KSRank in #170, is apparently known in the literature as RSA (Regional Sensitivity Analysis). Therefore, I renamed the method and added the necessary documentation.