Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KS Rank sensitivity method #170

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Add KS Rank sensitivity method #170

merged 8 commits into from
Jul 19, 2024

Conversation

max-de-rooij
Copy link
Contributor

@max-de-rooij max-de-rooij commented Jul 15, 2024

Checklist

Implementation of #169. Name is up for debate.

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

add raw string annotation
KSRank is stochastic and slight variations in the outcome measures are possible. New tests check whether parameters are correctly identified as sensitive.
Make tests less sensitive to random variability in the sensitivity criterion. Also indicate the random variability influence in the documentation.
Use JuliaFormatter
Add more detailed explanation of f(Y) function signature, and fix typos in math.
Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add descriptions of the result struct's fields?

Add description of returned KSRankResult struct
@Vaibhavdixit02 Vaibhavdixit02 merged commit ca21487 into SciML:master Jul 19, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants