Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor things #7

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Minor things #7

merged 3 commits into from
Oct 9, 2018

Conversation

jagot
Copy link
Contributor

@jagot jagot commented Oct 7, 2018

@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files           6        6           
  Lines         223      223           
=======================================
  Hits          216      216           
  Misses          7        7
Impacted Files Coverage Δ
src/krylov_expv.jl 90% <100%> (ø) ⬆️
src/arnoldi.jl 95.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ed363...dfdfb75. Read the comment docs.

@ChrisRackauckas
Copy link
Member

When this tags, OrdinaryDiffEq should get a minor update which bumps the minimum version to the new tag, then the cache fallback can be dropped, and then OrdinaryDiffEq.jl can safely drop it. That is a zero-hiccup deprecation that's nice and clean. Sorry it has an extra step but keeping tests green and not force merging to METADATA is just nicer overall. (Technically we should have a maximum version bound in there, but we can ignore that because it gives the resolver issues)

@MSeeker1340 MSeeker1340 merged commit 0d33e9f into SciML:master Oct 9, 2018
@MSeeker1340
Copy link
Contributor

I'll tag this now and after this gets registered, I'll push the corresponding OrdinaryDiffEq.jl version bump.

@jagot Are you planning on more changes to ExponentialUtilities.jl? I see that there're still things on the plate in #1.

@jagot
Copy link
Contributor Author

jagot commented Oct 9, 2018

Short-term, no. Long-term, probably.

  • In the future, I'll want to work with multi-electron problems, which will require partitioning of the state vector, in which case the type agnosticism à la KrylovKit.jl will come in handy.
  • I'll also be exploring various absorbing boundaries, that will yield complex-symmetric operators, rather than Hermitian ones, at which point I'll need the Arnoldi to work with the alternative interface. However, whilst looking into that, I did not get hseqr2 (QR/Schur factorization of upper Hessenberg matrices) working properly. On top of that, implementing an optimized exponentiator for triangular matrices, as described by Davies and Higham (2003), is slightly daunting at the moment. Such a routine should go into Base.LinearAlgebra, I guess. One "easy" way out is to butcher Base.LinearAlgebra.exp! and turn it into a cache-friendly version. This would not, however, utilize the upper-Hessenbergness (?) of the subspace matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants