Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes to ExponentialUtilities.jl to the ExpRK integrators #517

Closed
MSeeker1340 opened this issue Oct 6, 2018 · 5 comments
Closed
Assignees

Comments

@MSeeker1340
Copy link
Contributor

SciML/ExponentialUtilities.jl#1

Currently the only breaking change is the dropping of cache in expv(!) and phiv(!).

@MSeeker1340 MSeeker1340 self-assigned this Oct 6, 2018
@ChrisRackauckas
Copy link
Member

How do you plan to do the breaking change?

@MSeeker1340
Copy link
Contributor Author

For now fc257d5 will do. Since @jagot is still actively developing on his part I would expect more breaking changes in the future, at which point I'll implement those in OrdinaryDiffEq along the way. And after that we can merge the branch and push a release for both ExponentialUtilities and OrdinaryDiffEq.

@ChrisRackauckas
Copy link
Member

That's fine if ExponentialUtilities.jl gets a major version bump and if we bump the minimum required version here to that major version. For compatibility, it should pass through a no-op that drops the cache argument, but it's fine. If the cache argument isn't passed anymore, where does the cache array come from? I assume it's just allocated now?

@MSeeker1340
Copy link
Contributor Author

It now uses the next column of the V matrix as the cache and thus eliminates the need for external caches.

For compatibility, it should pass through a no-op that drops the cache argument, but it's fine.

@jagot can you do this alongside whatever's next in your plate? Just add back the cache argument and document somewhere about future deprecation?

@MSeeker1340
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants