ci: update tests workflow to use centralized reusable workflow and auto-suggest formatting changes on PRs

.github/workflows/FormatCheck.yml

@@ -10,4 +10,4 @@ on:
 jobs:
   format-check:
     name: "Format Check"
-    uses: "SciML/.github/.github/workflows/format-check.yml@v1"
+    uses: "SciML/.github/.github/workflows/format-suggestions-on-pr.yml@v1"

.github/workflows/Tests.yml

@@ -0,0 +1,40 @@
+name: "Tests"
+
+on:
+  pull_request:
+    branches:
+      - master
+      - 'release-'
+    paths-ignore:
+      - 'docs/**'
+  push:
+    branches:
+      - master
+    paths-ignore:
+      - 'docs/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref_name != github.event.repository.default_branch || github.ref != 'refs/tags/v*' }}
+
+env:
+  RETESTITEMS_NWORKERS: 4
+  RETESTITEMS_NWORKER_THREADS: 2
+
+jobs:
+  tests:
+    name: "Tests"
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - "ubuntu-latest"
+          - "macos-latest"
+          - "windows-latest"
+        group:
+          - "CPU"
+    uses: "SciML/.github/.github/workflows/tests.yml@v1"
+    with:
+      os: "${{ matrix.os }}"
+      group: "${{ matrix.group }}"
+    secrets: "inherit"

src/adaptivity.jl

@@ -237,7 +237,7 @@ function sum_stages!(z::AbstractArray, cache::MIRKCache, w, i::Int, dt = cache.m
     __maybe_matmul!(z, k_discrete[i].du[:, 1:stage], w[1:stage])
     __maybe_matmul!(
         z, k_interp.u[i][:, 1:(s_star - stage)], w[(stage + 1):s_star], true, true)
-    z .= z .* dt .+ cache.y₀[i]
+    z .= z .* dt .+ cache.y₀.u[i]
 
     return z
 end

src/default_nlsolve.jl

@@ -18,8 +18,7 @@ function __FastShortcutBVPCompatibleNLLSPolyalg(
                 linsolve, precs, disable_geodesic = Val(true), autodiff, kwargs...),
             TrustRegion(; concrete_jac, linsolve, precs, autodiff, kwargs...),
             GaussNewton(; concrete_jac, linsolve, precs,
-                linesearch = LineSearchesJL(; method = BackTracking()),
-                autodiff, kwargs...),
+                linesearch = BackTracking(), autodiff, kwargs...),
             LevenbergMarquardt(; linsolve, precs, autodiff, kwargs...))
     end
     return NonlinearSolvePolyAlgorithm(algs, Val(:NLLS))
@@ -32,8 +31,8 @@ function __FastShortcutBVPCompatibleNonlinearPolyalg(
         algs = (NewtonRaphson(; concrete_jac, linsolve, precs, autodiff),)
     else
         algs = (NewtonRaphson(; concrete_jac, linsolve, precs, autodiff),
-            NewtonRaphson(; concrete_jac, linsolve, precs,
-                linesearch = LineSearchesJL(; method = BackTracking()), autodiff),
+            NewtonRaphson(;
+                concrete_jac, linsolve, precs, linesearch = BackTracking(), autodiff),
             TrustRegion(; concrete_jac, linsolve, precs, autodiff))
     end
     return NonlinearSolvePolyAlgorithm(algs, Val(:NLS))

src/utils.jl

@@ -386,4 +386,4 @@ end
 @inline (f::__Fix3{F})(a, b) where {F} = f.f(a, b, f.x)
 
 
-# convert every vector of vector to AbstractVectorOfArray, especially if them come from get_tmp of PreallocationTools.jl
+# convert every vector of vector to AbstractVectorOfArray, especially if them come from get_tmp of PreallocationTools.jl

test/mirk/mirk_basic_tests.jl

@@ -82,7 +82,7 @@ end
         prob = probArr[i]
         @testset "MIRK$order" for order in (2, 3, 4, 5, 6)
             sol = solve(prob, mirk_solver(Val(order)); dt = 0.2)
-            @test norm(diff(first.(sol.u)) .+ 0.2, Inf) + abs(sol[1][1] - 5) < affineTol
+            @test norm(diff(first.(sol.u)) .+ 0.2, Inf) + abs(sol.u[1][1] - 5) < affineTol
         end
     end
 end

test/mirk/nlls_tests.jl

@@ -21,7 +21,7 @@
 
     for solver in SOLVERS
         sol = solve(bvp1, solver; verbose = false, dt = 1.0)
-        @test norm(bc1(sol, nothing, tspan), Inf) < 1e-2
+        @test norm(bc1(sol, nothing, sol.t), Inf) < 1e-2
     end
 
     # IIP MP-BVP
@@ -62,7 +62,7 @@
 
     for solver in SOLVERS
         sol = solve(bvp3, solver; verbose = false, dt = 1.0)
-        @test norm(vcat(bc1a(sol[1], nothing), bc1b(sol[end], nothing)), Inf) < 1e-2
+        @test norm(vcat(bc1a(sol.u[1], nothing), bc1b(sol.u[end], nothing)), Inf) < 1e-2
     end
 
     # IIP TP-BVP

test/mirk/vectorofvector_initials_tests.jl

@@ -55,9 +55,9 @@
     # The BVP set up
     # This is not really kind of Two-Point BVP we support.
     function bc_po!(residual, u, p, t)
-        residual[1] = u[:, 1][1] - u[end][1]
-        residual[2] = u[:, 1][2] - u[end][2]
-        residual[3] = u[:, 1][3] - u[end][3]
+        residual[1] = u[:, 1][1] - u[:, end][1]
+        residual[2] = u[:, 1][2] - u[:, end][2]
+        residual[3] = u[:, 1][3] - u[:, end][3]
     end
 
     #This is the part of the code that has problems

test/misc/bigfloat_test.jl

@@ -8,8 +8,8 @@
         du[2] = -9.81 * sin(θ)
     end
     function bc!(residual, u, p, t)
-        residual[1] = u[end ÷ 2][1] + big(pi / 2)
-        residual[2] = u[end][1] - big(pi / 2)
+        residual[1] = u[:, end ÷ 2][1] + big(pi / 2)
+        residual[2] = u[:, end][1] - big(pi / 2)
     end
     u0 = BigFloat.([pi / 2, pi / 2])
     prob = BVProblem(simplependulum!, bc!, u0, tspan)

test/misc/manifolds_tests.jl

@@ -58,15 +58,10 @@
         return vcat(t * a1 + (1 - t) * a2, zero(a1))
     end
 
-    function initial_guess_2(t)
-        a1, a2 = [0.5, -1.2], [-0.5, 0.3]
-        return vcat(t * a1 + (1 - t) * a2, zero(a1))
-    end
-
     algs = [Shooting(Tsit5()), MultipleShooting(10, Tsit5()), MIRK4(), MIRK5(), MIRK6()]
 
-    @testset "Initial Guess Functions: $(u0)" for u0 in (initial_guess_1, initial_guess_2)
-        bvp = BVProblem(chart_log_problem!, bc1!, u0, tspan, (M, i, a1, a2))
+    @testset "Initial Guess Functions" begin
+        bvp = BVProblem(chart_log_problem!, bc1!, initial_guess_1, tspan, (M, i, a1, a2))
 
         for alg in algs
             if alg isa Shooting || alg isa MultipleShooting

test/misc/non_vector_input_tests.jl

@@ -53,7 +53,7 @@
 
         @testset "Single Shooting" begin
             for prob in probs
-                sol = solve(prob, Shooting(Tsit5()))
+                sol = solve(prob, Shooting(Tsit5(), NewtonRaphson()))
                 @test norm(boundary(sol, prob.p, nothing), Inf) < 0.01
             end
         end

test/misc/type_stability_tests.jl

@@ -7,7 +7,7 @@
         du[2] = p[3] * u[1] * u[2] - p[4] * u[2]
     end
 
-    bc(sol, p, t) = [sol[1][1] - 1, sol[end][2] - 2]
+    bc(sol, p, t) = [sol[:, 1][1] - 1, sol[:, end][2] - 2]
     function bc!(res, sol, p, t)
         res[1] = sol[:, 1][1] - 1
         res[2] = sol[:, end][2] - 2