-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update tests workflow to use centralized reusable workflow and auto-suggest formatting changes on PRs #204
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@ErikQQY is it sometimes an array sometimes an AbstractVectorOfArray? We should probably always make it an AbstractVectorofArray |
We always use |
Yes, Make it an AbstractDiffEqArray, since there's time associated with it as well. |
410ffa4
to
8a251a9
Compare
This reverts commit 8a251a9.
@ErikQQY can you help with the completion of this? |
Sure, I will help to get this complete |
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
The errors in this PR are mostly caused by the deprecation of indexing methods in RecursiveArrayTools.jl: There are two ways of specifying boundary conditions when constructing a So here is the solution: We need to change the convention of defining boundary conditions as |
Yes, that's what needs to happen everywhere. |
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@avik-pal do you know why this ambiguity is still reported? I don't see it actually being hit? |
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
The Windows CI test looks weird, all other tests are working fine |
Follow up to #183.