chore(OnyxFlyoutMenu)!: Replace VNode dependency with slot parameters #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 656a4ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… BREAKING CHANGE: button slot now provides a trigger parameter which must be bound to the interactive element - feat(OnyxFlyoutMenu): BREAKING CHANGE: Renamed "default" slot to "button"
JoCa96
force-pushed
the
joca96/1595-prep-chore-use-slot-props-user-menu-flyout
branch
from
31c5f43 to
656a4ae
Compare
JoCa96
changed the title
larsrickert
approved these changes
Nov 20, 2024
JoCa96
deleted the
joca96/1595-prep-chore-use-slot-props-user-menu-flyout
branch
larsrickert
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1595
In preparation to support nesting.