Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define NavBar feature (Nesting, Selection) #1595

Closed
mj-hof opened this issue Jul 23, 2024 · 0 comments
Closed

Define NavBar feature (Nesting, Selection) #1595

mj-hof opened this issue Jul 23, 2024 · 0 comments
Assignees
@JoCa96
Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise ux Requires UX/UI design
Milestone
Navigation bars

Comments

@mj-hof
Copy link
Collaborator

mj-hof commented Jul 23, 2024 •
edited by JoCa96
Loading

For the WaWi we need the following features in NavBar:

  • Keyboard and Shortcut support
  • OnyxKey component must still be implemented
  • Multi-Level Nested MenuItem need to be supported
  • MenuSelect needs to be supported (value is reflected in the triggering element)

Based on this, the NavBar needs to allow for the following structure:

  • NavBar
    • AppArea ("Home Button")
    • NavButton ("Jump to Page or Action")
    • FlyoutMenu ("List of Pages or Action")
      • MenuItem ("Jump to Page or Action")
      • MenuList
        • MenuItem
          • -> recursion
    • MenuSelect ("Selection")
    • MenuItem
    • MenuList
      • MenuItem
        • -> recursion

Aria pattern:

Result of ticket
@mj-hof mj-hof added this to onyx Jul 23, 2024
@mj-hof mj-hof converted this from a draft issue Jul 23, 2024
@mj-hof mj-hof added dev Requires technical expertise po Requires project management ux Requires UX/UI design labels Jul 23, 2024
@mj-hof mj-hof moved this from New to Backlog in onyx Jul 23, 2024
@mj-hof mj-hof added the cooperation Issues for projects in cooperative mode label Jul 23, 2024
@mj-hof mj-hof added this to the Navigation bars milestone Jul 23, 2024
@mj-hof mj-hof changed the title Define MenuBar component Define NavBar feature (Nesting, Selection) Jul 24, 2024
@mj-hof mj-hof moved this from Backlog to Ready in onyx Jul 24, 2024
@JoCa96 JoCa96 assigned jannick-ux and unassigned jannick-ux Oct 2, 2024
@JoCa96 JoCa96 self-assigned this Oct 10, 2024
@JoCa96 JoCa96 mentioned this issue Nov 20, 2024
Merged
JoCa96 added a commit that referenced this issue Nov 20, 2024
@JoCa96
chore(OnyxFlyoutMenu)!: Replace VNode dependency with slot parameters (…
4a4c414 
…#2123)

Relates to #1595 

In preparation to support nesting.


- Added component tests for the flyout menu
- Replaced the VNodes unwrapping with slot parameters to avoid reliance
on Vue internals
- feat(OnyxNavButton, OnyxUserMenu, OnyxFlyoutMenu): button slot now
provides a trigger parameter which must be bound to the interactive
element
  - feat(OnyxFlyoutMenu): Renamed "default" slot to "button"
@JoCa96 JoCa96 mentioned this issue Nov 27, 2024
Open
19 tasks
@JoCa96 JoCa96 moved this from In Progress to Done in onyx Nov 27, 2024
@JoCa96 JoCa96 closed this as completed Nov 27, 2024
@mj-hof mj-hof removed the po Requires project management label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoCa96 JoCa96

Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise ux Requires UX/UI design
Projects
onyx
Status: Done
Milestone
Navigation bars
Development

No branches or pull requests
3 participants
@JoCa96 @mj-hof @jannick-ux