Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement OnyxColorSchemeMenuItem #1465

Merged
merged 16 commits into from
Jul 2, 2024
Merged

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Jul 1, 2024

related to #1474

Implement OnyxColorSchemeMenuItem for easily letting the user choose light/dark/auto mode inside the user menu

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner July 1, 2024 11:26
Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: 060baf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Minor
alpha-test-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BoppLi BoppLi self-assigned this Jul 1, 2024
Copy link
Contributor

@BoppLi BoppLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 / 18 reviewed

larsrickert and others added 5 commits July 1, 2024 17:00
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
@larsrickert larsrickert requested a review from BoppLi July 1, 2024 15:37
@larsrickert larsrickert enabled auto-merge (squash) July 2, 2024 07:58
@larsrickert larsrickert requested a review from BoppLi July 2, 2024 07:58
@larsrickert larsrickert merged commit 90f9f86 into main Jul 2, 2024
19 checks passed
@larsrickert larsrickert deleted the feat/color-scheme-menu-item branch July 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants