-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement OnyxColorSchemeMenuItem #1465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
🦋 Changeset detectedLatest commit: 060baf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/sit-onyx/src/components/OnyxColorSchemeMenuItem/OnyxColorSchemeMenuItem.ct.tsx
Fixed
Show fixed
Hide fixed
BoppLi
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 / 18 reviewed
packages/sit-onyx/src/components/OnyxColorSchemeMenuItem/OnyxColorSchemeMenuItem.ct.tsx
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxColorSchemeMenuItem/OnyxColorSchemeMenuItem.ct.tsx
Outdated
Show resolved
Hide resolved
BoppLi
requested changes
Jul 1, 2024
packages/sit-onyx/src/components/OnyxColorSchemeMenuItem/OnyxColorSchemeMenuItem.vue
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxColorSchemeMenuItem/OnyxColorSchemeMenuItem.stories.ts
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
BoppLi
approved these changes
Jul 1, 2024
packages/sit-onyx/src/components/OnyxColorSchemeDialog/OnyxColorSchemeDialog.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxColorSchemeDialog/OnyxColorSchemeDialog.ct.tsx
Outdated
Show resolved
Hide resolved
BoppLi
requested changes
Jul 1, 2024
BoppLi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1474
Implement
OnyxColorSchemeMenuItem
for easily letting the user choose light/dark/auto mode inside the user menuChecklist
apps/docs
)npx changeset add
if your changes should be released as npm package (because they affect the library usage)