Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement color scheme menu item #1474

Closed
11 tasks done
larsrickert opened this issue Jul 2, 2024 · 0 comments
Closed
11 tasks done

Implement color scheme menu item #1474

larsrickert opened this issue Jul 2, 2024 · 0 comments
Assignees
@larsrickert
Labels
dev Requires technical expertise
Milestone
Navigation bars

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Jul 2, 2024 •
edited by jannick-ux
Loading

Why?

We want to implement a pre-build menu item for the user menu that allows selecting the appearance light/dark/auto using the existing OnyxColorSchemeDialog.

Design

Figma

Acceptance criteria

  • the menu item is implemented and can be used inside the OnyxUserMenu
  • the theming docs are updated

Definition of Done

  • The following component requirements are implemented:
    • example usage added to apps/alpha-test-app/src/views/HomeView.vue
  • covered by component tests
  • screenshot tests are updated
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly
  • Set task to In Approval

Approval
@larsrickert larsrickert added this to onyx Jul 2, 2024
@larsrickert larsrickert self-assigned this Jul 2, 2024
@larsrickert larsrickert converted this from a draft issue Jul 2, 2024
@larsrickert larsrickert added the dev Requires technical expertise label Jul 2, 2024
@larsrickert larsrickert added this to the Navigation bars milestone Jul 2, 2024
@larsrickert larsrickert mentioned this issue Jul 2, 2024
Merged
4 tasks
@BoppLi BoppLi moved this from In Progress to In Approval in onyx Jul 3, 2024
@github-project-automation github-project-automation bot moved this from In Approval to Done in onyx Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsrickert larsrickert

Labels
dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Navigation bars
Development

No branches or pull requests
1 participant
@larsrickert