Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changed github user profile picture causing breaking CI screenshot tests #2106

Closed
JoCa96 opened this issue Nov 18, 2024 · 0 comments · Fixed by #2105
Closed

Fix changed github user profile picture causing breaking CI screenshot tests #2106

JoCa96 opened this issue Nov 18, 2024 · 0 comments · Fixed by #2105
Assignees
@JoCa96
Labels
dev Requires technical expertise
Milestone
Product improvements

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented Nov 18, 2024

No description provided.

@JoCa96 JoCa96 added the bug label Nov 18, 2024
@JoCa96 JoCa96 self-assigned this Nov 18, 2024
@JoCa96 JoCa96 added this to onyx Nov 18, 2024
@JoCa96 JoCa96 moved this to In Progress in onyx Nov 18, 2024
@JoCa96 JoCa96 mentioned this issue Nov 18, 2024
Merged
JoCa96 added a commit that referenced this issue Nov 18, 2024
@JoCa96 @github-actions
fix(CI): fix changed github user profile picture causing breaking CI …
514516c 
…screenshot tests (#2105)

### Root cause

The `ComponentShowcase` Vue component has some hardcoded example
avatars, where the images are loaded from GitHub.
The Screenshot tests fail because an avatar image on GitHub was updated,
and therefore the saved screenshot doesn't match anymore.

### Fix

This is fixed by intercepting the avatar image request in the screenshot
test and always returning the same, static image.
Closes #2106

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: JoCa96 <[email protected]>
@github-project-automation github-project-automation bot moved this from In Approval to Done in onyx Nov 18, 2024
@mj-hof mj-hof added this to the Product improvements milestone Nov 20, 2024
@mj-hof mj-hof added the dev Requires technical expertise label Nov 21, 2024
@mj-hof mj-hof removed the bug label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoCa96 JoCa96

Labels
dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Product improvements
Development

Successfully merging a pull request may close this issue.

fix(CI): fix changed github user profile picture causing breaking CI screenshot tests SchwarzIT/onyx
2 participants
@JoCa96 @mj-hof