fix(CI): fix changed github user profile picture causing breaking CI screenshot tests #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MajaZarkova
approved these changes
Nov 18, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: JoCa96 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The
ComponentShowcaseVue component has some hardcoded example avatars, where the images are loaded from GitHub.The Screenshot tests fail because an avatar image on GitHub was updated, and therefore the saved screenshot doesn't match anymore.
Fix
This is fixed by intercepting the avatar image request in the screenshot test and always returning the same, static image.
Closes #2106