Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #1520] Replace hard-coded shell paths #1523

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

dboitnot
Copy link
Contributor

@dboitnot dboitnot commented Oct 3, 2024

Resolve #1520 - Replaced hard-coded shell paths

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@alex-harvey-z3q
Copy link
Contributor

I don't understand what those tests are even doing but seems fine to approve to me!

@alex-harvey-z3q alex-harvey-z3q changed the title fix(1520) - Replaced hard-coded shell paths [Resolve #1520] Replace hard-coded shell paths Oct 5, 2024
@alex-harvey-z3q alex-harvey-z3q merged commit e344f2d into Sceptre:master Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_cmd.py::test_hook_writes_to_stderr fails in a nix environment
3 participants