Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_cmd.py::test_hook_writes_to_stderr fails in a nix environment #1520

Closed
dboitnot opened this issue Oct 3, 2024 · 0 comments · Fixed by #1523
Closed

test_cmd.py::test_hook_writes_to_stderr fails in a nix environment #1520

dboitnot opened this issue Oct 3, 2024 · 0 comments · Fixed by #1523
Assignees
@dboitnot
Labels
state: has pr type: bug

Comments

@dboitnot
Copy link
Contributor

dboitnot commented Oct 3, 2024

Subject of the issue

The paths to sh and bash are hard-coded into these tests:

  • test_default_shell_is_sh
  • test_shell_parameter_sets_the_shell

Your environment

  • Sceptre, version 4.5.2
  • Python 3.12.5
  • NixOS

Steps to reproduce

poetry run tox in any environment where sh and bash aren't under /bin

Expected behaviour

Tests should pass.

Actual behaviour

The tests listed above fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dboitnot dboitnot

Labels
state: has pr type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Resolve #1520] Replace hard-coded shell paths dboitnot/sceptre
1 participant
@dboitnot