fix(chat): offline msgs order #4794
Conversation
github-actions
bot
added
the
Missing Dev Review
| message.payload.body.messages | ||
| .sort((a, b) => a.createdAt - b.createdAt) | ||
| .map(async (message) => { | ||
| const stored = await iridium.connector?.dag.get( |
There was a problem hiding this comment.
I think we can use iridium.load and skip the manual decryption step
There was a problem hiding this comment.
for some reasons the await iridium.connector?.load(msg.cid) fails:
There was a problem hiding this comment.
thats because on iridium it loads this:
we should have object.body instead, where is the error? on core when storing the message?
There was a problem hiding this comment.
ok, maybe something about the structure of the payload. I'll take a look in a followup.
|
I am seeing weird issues where the offline messages don't come in consistently, or they will show up, then on reload they dissapear. Do you think this should be looked at in a follow up pr? Or maybe it works with your edit message pr, i will check that out now |
|
Those should not be related to these PRs, are you experiencing the same on dev? |
|
@molimauro I also tested this one as well and wanted to leave a little note of my findings. I was able to add friends and send messages from both sides and still not receive them on either side Screen.Recording.2022-09-14.at.1.47.31.PM.mov |
|
@phillsatellite i tried and they worked on my side but ill try to dig more |
molimauro
force-pushed
the
fix_offline_messages
branch
from
fa54eb1 to
85ffdff
Compare
WanderingHogan
force-pushed
the
fix_offline_messages
branch
from
85ffdff to
e53e517
Compare
|
I think the inconsistency should be addressed in recently merged branches. if not I will follow up on this. |
github-actions
bot
removed
the
Missing Dev Review
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤
After this we can merge #4755 too