feat(chat): edit messages #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
phillsatellite
approved these changes
Sep 13, 2022
phillsatellite
added
the
QA tested
josephmcg
reviewed
Sep 14, 2022
|
this is so sweet, i think we should hold off until we figure out the offline piece of it though since we are so close to EA, what do you all think? |
No problem of course ;) |
|
If we merge #4794 we can then merge this if its okay for you |
github-actions
bot
added
missing fixing conflict
github-actions
bot
added
the
missing fixing conflict
molimauro
force-pushed
the
edit_chat_messages
branch
from
2b4419d to
d85ad60
Compare
github-actions
bot
removed
the
missing fixing conflict
WanderingHogan
approved these changes
Sep 19, 2022
WanderingHogan
added
Ready for QA
WanderingHogan
force-pushed
the
edit_chat_messages
branch
from
d85ad60 to
731bffd
Compare
|
@stavares843 @phillsatellite can you check this and merge if okay, otherwise comment here with screenshots please check across all browsers, mac/win |
stavares843
approved these changes
Sep 19, 2022
stavares843
force-pushed
the
edit_chat_messages
branch
from
731bffd to
c8cb8e3
Compare
github-actions
bot
removed
the
Ready for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Implement message edit functionality.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
If you send a new message and edit it while the other user is offline, the latter will receive the original copy. (same problem of the reactions while offline)
Additional comments 🎤
Noticing some problems with the enhancers, disabled here, will fix on a separate PR.