fix(typing-indicator): restored indicator #4734
Conversation
github-actions
bot
added
the
Missing Dev Review
|
Only 2 small things I found that I will create tickets for in the QA Jira board just wanted to share findings here as well, iOS typing indicator was appearing wrong and I noticed it didnt appear for Groupchats either but other than those 2 small things it worked extremely well! 🔥 |
phillsatellite
added
the
QA tested
|
Thanks @phillsatellite! The group thing is not a bug, it’s intended :) we ll look into the ios bug though!! Thanks ;) all good on android? |
| ) | ||
| : false | ||
| finalMask(): string { | ||
| if (this.isTyping) { |
There was a problem hiding this comment.
This should be redundant
|
thanks for testing @phillsatellite 💥 thanks for clarifying @molimauro 🔨 |
josephmcg
force-pushed
the
fix-typing-sidebar
branch
from
bd921ca to
39545c5
Compare
| (this.conversation.id && | ||
| this.ephemeral.typing[this.conversation.id][this.user.did]) || | ||
| false |
There was a problem hiding this comment.
Hey Thomas!
Tried adding a new friend but was met with this error. It might be good to include guard clauses here for if the conversation doesn't exist yet for the user, and if the data for the user is not yet available.
There was a problem hiding this comment.
i saw this error before on dev as well
github-actions
bot
added
the
missing fixing conflict
|
#4745 I opted for a conversationId prop to determine typing status render because the sidebarListItem component doesn't need to be aware of typing status. It was only calculating it to pass as a prop. In that case, I think it's better to handle everything in the child component. This will also work well with a new group member sidebar I have in progress here |
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤