Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): new group member sidebar for group chats #4747

Merged
merged 3 commits into from
Sep 14, 2022
Merged

feat(chat): new group member sidebar for group chats #4747

merged 3 commits into from
Sep 14, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 13, 2022 •
edited
Loading

What this PR does 📖

  • create new sidebar for group chats to display user list and online/typing status

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

  • This does not show your own typing status in the group sidebar. I think that should be a separate ticket because it has potential to introduce bugs
  • This can be built upon. maybe add some click logic/context menus eventually

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 13, 2022
@josephmcg josephmcg linked an issue Sep 13, 2022 that may be closed by this pull request
chat - group sidebar for online and typing status #4725
Closed
@josephmcg josephmcg added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Sep 13, 2022
@josephmcg josephmcg mentioned this pull request Sep 13, 2022
Closed
@josephmcg josephmcg changed the title feat(sidebar): show group members in group chat feat(chat): new group member sidebar for group chats Sep 13, 2022
molimauro
molimauro reviewed Sep 13, 2022
View reviewed changes
pages/chat/Chat.html Outdated Show resolved Hide resolved
@josephmcg josephmcg removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Sep 13, 2022
@WanderingHogan WanderingHogan added ready to merge and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 14, 2022
@josephmcg josephmcg merged commit 905573b into dev Sep 14, 2022
@josephmcg josephmcg deleted the groupChatSidebar branch September 14, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molimauro molimauro molimauro left review comments

@WanderingHogan WanderingHogan WanderingHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chat - group sidebar for online and typing status
3 participants
@josephmcg @WanderingHogan @molimauro