feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavares843
added
the
Missing Dev Review
stavares843
reviewed
Nov 27, 2021
libraries/WebRTC/Emitter.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * @method off | ||
| * @description Removes an event listener from the listener box | ||
| * @param event WebRTCEvent to unsubscribe from | ||
| * @param event event to unsubscribe from |
libraries/WebRTC/Wire.ts
Outdated
|
|
||
| /** | ||
| * @constructor | ||
| * @param originator Idendifier of the originator |
InfamousVague
approved these changes
Nov 29, 2021
InfamousVague
pushed a commit
that referenced
this pull request
Dec 1, 2021
… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 2, 2021
* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <[email protected]> Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
… and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <[email protected]> Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]>
stavares843
removed
the
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Adds abstractions for low level p2p connections
Which issue(s) this PR fixes 🔨
No issues, it's a new feature
Special notes for reviewers 🗒️
I had troubles with the new eslint configuration. I had to add a specific rule for prettier to make it work.
The p2pt library that has been installed comes from our internal repo Satellite-im/P2PT. It should not cause issues, but it's better to know, just in case.
yarn installcommand is requiredAdditional comments 🎤
A low level class named Wire can be used to connect two different peers on a specific channel in an easy way. It automatically makes the connection happen using Web Torrent signaling servers. An higher level class named Call can be used to initiate an audio/video conversation between two different peers. It makes use of a previously created Wire for the signaling part. Both classes are supposed to be combined together for creating the top level abstractions WebRTCUser and WebRTCManager.