fix(message): update timestamp message every minute #300

vimercati-samir · 2021-11-23T17:02:49Z

What this PR does 📖
Update timestamp message every minute

Which issue(s) this PR fixes 🔨
timestamp message not updating (‘A few seconds ago' for ever unless component rebuilds)

Fixes #AP-43

Special notes for reviewers 🗒️

Additional comments 🎤

stavares843

so it no longer gets stuck showing a few seconds ago

when sending a message says a few seconds ago and then updates to a minute ago, 2 minutes ago, and so on

but the thing is, when you send a message and then wait 5 minutes and send another message, all those messages shows that were sent 5 minutes ago, even if the oldest one was 5m ago and the newest one was a couple of seconds ago

I'm gonna approve this because that's probably to be handled on other PR, let me know cc @WanderingHogan

WanderingHogan · 2021-11-24T05:42:55Z

@stavares843 just added a few tickets to address what you brought up: AP-106 and AP-107

WanderingHogan

great idea with clearInterval when you tear down the component

InfamousVague · 2021-11-24T06:26:08Z

components/tailored/messaging/group/Group.vue

+    refreshTimestampEveryMinute() {
+      this.timestampRefreshInterval = setInterval(() => {
+        this.$data.timestamp = this.$dayjs(this.group.at).from()
+      }, 60 * 1000)


Can we move this to a config value?

InfamousVague · 2021-11-24T06:26:22Z

components/tailored/messaging/message/Message.vue

+    refreshTimestampEveryMinute() {
+      this.timestampRefreshInterval = setInterval(() => {
+        this.$data.timestamp = this.$dayjs(this.$props.message.at).from()
+      }, 60 * 1000)


Config value

I suggest

chat: { defaultMessageLimit: 50, defalutLoadMoreLimit: 20, timestampUpdateInterval: 60 * 1000, },

* Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]>

… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]>

* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <[email protected]> Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]>

* chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]>

* Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]>

… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]>

* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <[email protected]> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]> Co-authored-by: Chris Hogan <[email protected]> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <[email protected]> Co-authored-by: Manuel Tumiati <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Matt Wisniewski <[email protected]> Co-authored-by: Sara Tavares <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: vimercati-samir <[email protected]> Co-authored-by: Samir Vimercati <[email protected]> Co-authored-by: Jeff Kristian <[email protected]> Co-authored-by: David Chan <[email protected]>

stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Nov 23, 2021

stavares843 approved these changes Nov 23, 2021

View reviewed changes

stavares843 added QA tested QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. QA tested labels Nov 23, 2021

WanderingHogan approved these changes Nov 24, 2021

View reviewed changes

InfamousVague requested changes Nov 24, 2021

View reviewed changes

stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Nov 24, 2021

vimercati-samir added 2 commits November 24, 2021 17:26

chore: rebase dev

80f7925

chore(message): changes in response to pr review

30a1c83

stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Nov 24, 2021

InfamousVague approved these changes Nov 26, 2021

View reviewed changes

InfamousVague merged commit 3d9c417 into Satellite-im:dev Nov 26, 2021

InfamousVague pushed a commit that referenced this pull request Dec 5, 2021

fix(message): update timestamp message every minute (#300)

b31eda6

* chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <[email protected]>

stavares843 removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(message): update timestamp message every minute #300

fix(message): update timestamp message every minute #300

vimercati-samir commented Nov 23, 2021

stavares843 left a comment

WanderingHogan commented Nov 24, 2021

WanderingHogan left a comment

InfamousVague Nov 24, 2021

InfamousVague Nov 24, 2021

InfamousVague Nov 24, 2021

fix(message): update timestamp message every minute #300

fix(message): update timestamp message every minute #300

Conversation

vimercati-samir commented Nov 23, 2021

stavares843 left a comment

Choose a reason for hiding this comment

WanderingHogan commented Nov 24, 2021

WanderingHogan left a comment

Choose a reason for hiding this comment

InfamousVague Nov 24, 2021

Choose a reason for hiding this comment

InfamousVague Nov 24, 2021

Choose a reason for hiding this comment

InfamousVague Nov 24, 2021

Choose a reason for hiding this comment