feat(indexedDB): clean up searchIndex, indexeddb #2419

aewing · 2022-03-18T21:26:23Z

What this PR does 📖

Introduces the libraries/SatelliteDB library in place of the thirdparty dexie plugin (will revisit plugins as time allows)
Refactors the SearchIndex class a bit, leveraging minisearch in place of the previous dexie
Syncs new conversations, messages, and friends to indexeddb and search indexes

Which issue(s) this PR fixes 🔨
AP-979

Special notes for reviewers 🗒️

Additional comments 🎤
Feel free to reach out directly with any questions to try to keep the issue clean for other reviewers.

netlify · 2022-03-18T21:38:47Z

✅ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: c350e49

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6234f9007322140008b80cda

😎 Browse the preview: https://deploy-preview-2419--adoring-edison-dbcef8.netlify.app

libraries/SatelliteDB/SatelliteDB.test.ts

netlify · 2022-03-18T21:47:52Z

✅ Yeeeehaw, deploy preview is ready!

Name	Link
🔨 Latest commit	`c4d6682`
🔍 Latest deploy log	https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/623a228d226c6b0008a01ea9
😎 Deploy Preview	https://deploy-preview-2419--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stavares843 · 2022-03-20T19:53:23Z

/rebase

libraries/SatelliteDB/SatelliteDB.ts

stavares843

can you clarify exactly what is this PR adding related to the search?

I send messages saying ''a'', searched ''a'', no results found

is the search expected to be working on this PR?

josephmcg

I'll let Drew confirm, but I would guess it only searches after a certain character threshold. Searching for a single letter like 'a' wouldn't be very helpful since it would return any word with an 'a'. This seems like an under-the-hood change, UI updates coming in a later PR

stavares843 · 2022-03-22T01:26:21Z

well, last time this was tested the search was far from perfect

also, that info is nowhere to be found on the PR, if it has or not a threshold which doesn't even make sense having that because if a user wants to search only by a number or an emoji, he couldn't due to the threshold

stavares843 · 2022-03-22T01:29:41Z

tested again and ''a'' worked

but then tested ''test'' and crashed

then sent ''SATELLITE'' and searched again by ''SATELLITE'' and crashed

so this crash's everything you send something > search for that > crash

reload, crash is gone, send other keyword > search for that one > crash's again

stavares843 · 2022-03-22T04:08:59Z

also, both locally and CI the imported chats gets broken

is this something expected within this PR?

doesn't seem to be any useful error on the log

stavares843 · 2022-03-22T04:10:29Z

i also have that same issue with dexie when importing specific accounts, more details here

aewing · 2022-03-22T19:20:48Z

also, both locally and CI the imported chats gets broken

is this something expected within this PR?

doesn't seem to be any useful error on the log

I'm not seeing this issue when importing my account. When I attempt to import the seed phrase provided, I see a series of "Bad API key" messages locally, and it works in the dev environment.

stavares843 · 2022-03-22T19:23:38Z

very strange

thanks for checking 🔨

… indexeddb

aewing · 2022-03-22T19:29:18Z

tested again and ''a'' worked

but then tested ''test'' and crashed

then sent ''SATELLITE'' and searched again by ''SATELLITE'' and crashed

so this crash's everything you send something > search for that > crash

reload, crash is gone, send other keyword > search for that one > crash's again

Thanks for finding this. I was able to reproduce this issue and have added a fix (appended the conversation address to new messages before adding them to the index, so the user can be attached in the UI)

libraries/SatelliteDB/SatelliteDB.ts

WanderingHogan · 2022-03-22T21:50:58Z

@stavares843 dont worry about anything in search, we have an upcoming task for Joe to refactor/work that

stavares843 · 2022-03-22T22:53:27Z

dev

Gravacao.do.ecra.2022-03-22.as.22.50.33.mov

this branch

test0000001.mov

on dev, you send a glyph - that appears on the front of you
on this branch you send a glyph - that doesn't appear in front of you

WanderingHogan · 2022-03-22T23:38:04Z

i can't for the life of me replicate the problem you are having

stavares843 · 2022-03-22T23:38:34Z

so shady

stavares843 · 2022-03-22T23:48:46Z

Gravacao.do.ecra.2022-03-22.as.23.45.27.mov

flow

go to dev
send something
appears in front of you (A)
scroll up
send something - will not appear in front of you, we don't have that type of scroll added yet (B)
scroll down
send something
appears in front of you (because you were all scrolled down like the A above)

then

go to this branch
send something
appears in front of you (A)
scroll up
send something - will not appear in front of you, we don't have that type of scroll added yet (B)
scroll down
send something
It DOESN'T appears in front of you (and you were all scrolled down like the A above so should be in front of you like dev)

aewing · 2022-03-23T00:59:59Z

Gravacao.do.ecra.2022-03-22.as.23.45.27.mov

flow

* go to dev

* send something

* appears in front of you (A)

* scroll up

* send something - will not appear in front of you, we don't have that type of scroll added yet (B)

* scroll down

* send something

* appears in front of you (because you were all scrolled down like the A above)

then

* go to this branch

* send something

* appears in front of you (A)

* scroll up

* send something - will not appear in front of you, we don't have that type of scroll added yet (B)

* scroll down

* send something

* It DOESN'T appears in front of you (and you were all scrolled down like the A above so should be in front of you like dev)

just tested this on #2407 and a few other branches and the issue is consistent across the open PRs right now.

stavares843 · 2022-03-23T01:02:08Z

on dev, is always good for me

Phil is checking as well

aewing · 2022-03-23T01:29:02Z

Satellite-Absolute.Mozilla.Firefox.2022-03-22.18-26-59.mp4

on dev.satellite.one

aewing force-pushed the AP-979 branch from c350e49 to 8f0eb09 Compare March 18, 2022 21:29

aewing marked this pull request as draft March 18, 2022 21:31

stavares843 reviewed Mar 18, 2022

View reviewed changes

libraries/SatelliteDB/SatelliteDB.test.ts Show resolved Hide resolved

stavares843 added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Mar 19, 2022

aewing marked this pull request as ready for review March 19, 2022 01:03

aewing added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed draft A developer wants eyes on this PR, but they don't think it's ready to merge. labels Mar 19, 2022

github-actions bot force-pushed the AP-979 branch from 8f0eb09 to 14f43ba Compare March 20, 2022 19:53

molimauro reviewed Mar 21, 2022

View reviewed changes

libraries/SatelliteDB/SatelliteDB.ts Outdated Show resolved Hide resolved

github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 21, 2022

aewing force-pushed the AP-979 branch from b7976e2 to 772ec3f Compare March 21, 2022 17:25

stavares843 removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 21, 2022

stavares843 requested changes Mar 21, 2022

View reviewed changes

stavares843 added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Mar 21, 2022

josephmcg approved these changes Mar 22, 2022

View reviewed changes

github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 22, 2022

feat(indexedDB): clean up searchIndex, lunr -> minisearch, friends in…

c4d6682

… indexeddb

aewing force-pushed the AP-979 branch from 3d73252 to c4d6682 Compare March 22, 2022 19:25

github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 22, 2022

WanderingHogan reviewed Mar 22, 2022

View reviewed changes

libraries/SatelliteDB/SatelliteDB.ts Show resolved Hide resolved

WanderingHogan approved these changes Mar 22, 2022

View reviewed changes

stavares843 added the temporary blocked checking something QA Lead is checking something. label Mar 22, 2022

stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. temporary blocked checking something QA Lead is checking something. labels Mar 22, 2022

WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Mar 23, 2022

stavares843 merged commit d78744d into dev Mar 23, 2022

stavares843 deleted the AP-979 branch March 23, 2022 01:53

github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indexedDB): clean up searchIndex, indexeddb #2419

feat(indexedDB): clean up searchIndex, indexeddb #2419

aewing commented Mar 18, 2022

netlify bot commented Mar 18, 2022

netlify bot commented Mar 18, 2022 •

edited

Loading

stavares843 commented Mar 20, 2022

stavares843 left a comment

josephmcg left a comment

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022 •

edited

Loading

aewing commented Mar 22, 2022 •

edited

Loading

stavares843 commented Mar 22, 2022

aewing commented Mar 22, 2022

WanderingHogan commented Mar 22, 2022

stavares843 commented Mar 22, 2022

WanderingHogan commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022 •

edited

Loading

aewing commented Mar 23, 2022

stavares843 commented Mar 23, 2022

aewing commented Mar 23, 2022

feat(indexedDB): clean up searchIndex, indexeddb #2419

feat(indexedDB): clean up searchIndex, indexeddb #2419

Conversation

aewing commented Mar 18, 2022

netlify bot commented Mar 18, 2022

netlify bot commented Mar 18, 2022 • edited Loading

✅ Yeeeehaw, deploy preview is ready!

stavares843 commented Mar 20, 2022

stavares843 left a comment

Choose a reason for hiding this comment

josephmcg left a comment

Choose a reason for hiding this comment

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022 • edited Loading

aewing commented Mar 22, 2022 • edited Loading

stavares843 commented Mar 22, 2022

aewing commented Mar 22, 2022

WanderingHogan commented Mar 22, 2022

stavares843 commented Mar 22, 2022

WanderingHogan commented Mar 22, 2022

stavares843 commented Mar 22, 2022

stavares843 commented Mar 22, 2022 • edited Loading

aewing commented Mar 23, 2022

stavares843 commented Mar 23, 2022

aewing commented Mar 23, 2022

netlify bot commented Mar 18, 2022 •

edited

Loading

stavares843 commented Mar 22, 2022 •

edited

Loading

aewing commented Mar 22, 2022 •

edited

Loading

stavares843 commented Mar 22, 2022 •

edited

Loading