Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signaling): ui update to soon allow user to set signaling servers #2407

Merged
merged 19 commits into from
Mar 23, 2022

Conversation

WanderingHogan
Copy link
Contributor

What this PR does 📖
These are fixes for David's PR #1815. This adds in a section when signing up and in settings that allows a user to change signaling servers.

This is only a UI update, and does not have any new functionality. Changing will not change the signaling servers used yet.

Which issue(s) this PR fixes 🔨
AP-1014

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 18, 2022
@github-actions
Copy link
Contributor

⚠️ The title of this PR is invalid.
Please make the title match this format <type>(<scope>): <description>.
e.g.)
add(cli): enable --verbose flag
fix(api): avoid unexpected error in handler

allowed types - add, update, task, chore, feat, test, fix

@WanderingHogan WanderingHogan changed the title Signal server UI combined feat(signaling): ui update to soon allow user to set signaling servers Mar 18, 2022
@netlify
Copy link

netlify bot commented Mar 18, 2022

Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 26d3da8
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/623b7929e880350008837a99
😎 Deploy Preview https://deploy-preview-2407--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stavares843
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the signal-server-ui-combined branch from b94753c to 405b7d0 Compare March 18, 2022 21:56
@stavares843 stavares843 added temporary blocked checking something QA Lead is checking something. Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA temporary blocked checking something QA Lead is checking something. labels Mar 18, 2022
@WanderingHogan WanderingHogan removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Mar 22, 2022
@stavares843
Copy link
Member

image

on sign up, there's no scroll 🔨 it breaks mobile sign up

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Mar 22, 2022
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 22, 2022
@stavares843
Copy link
Member

Unlock pin should be persisted when store pin is enabled -- Create Account with store pin disabled (failed)

is broken using 1000x600 screen on sign up

dev

Captura de ecrã 2022-03-22, às 22 56 34

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Mar 22, 2022
@stavares843
Copy link
Member

/rebase

@stavares843 stavares843 added Ready for QA Ready for QA team to test, Devs approved. Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. Ready for QA Ready for QA team to test, Devs approved. labels Mar 23, 2022
@stavares843
Copy link
Member

Gravacao.do.ecra.2022-03-23.as.16.53.20.mov

I can't scroll properly, if I try to scroll down, goes up

@stavares843 stavares843 added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Mar 23, 2022
@phillsatellite
Copy link
Contributor

phillsatellite commented Mar 23, 2022

In regards to Sara’s latest comment I tested on actual iOS device and it deep seem a little laggy

RPReplay_Final1648059830.mov

Plz download video github doesnt like my mobile recordings

@stavares843
Copy link
Member

thanks @phillsatellite 🎉

@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Mar 23, 2022
@phillsatellite phillsatellite removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 23, 2022
@stavares843 stavares843 merged commit 5a2dc96 into dev Mar 23, 2022
@stavares843 stavares843 deleted the signal-server-ui-combined branch March 23, 2022 21:44
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants