-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRONTEND: Update Screenshot functionality #2279
FRONTEND: Update Screenshot functionality #2279
Conversation
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
for the citation, if we're keeping in line with APA standards for electronic images, the format would generally be
in the above screenshot, for example, the citation would be formatted as
do you think we could alter the citation to match these standards? |
URL looks good at the bottom. I feel like the logo placement is a little strange still... sorry to nitpick but im just thinking if the goal is to have people "save as" and then embed, we want it to look as good as the charts do on the page. Is it a pain to try and put the logo+logo text on the very bottom, centered? Or @kccrtv do you have any suggestions on making the export look as good as possible? If we need to drop the logo we can; i thought it'd be cool but the primary goal is to make it lok good enough someone wants to share it Also @eriwarr , you noted that this PR closes #2186 , is that true? I thought you weren't able to get that fixed? |
@benhammondmusic - I understand. No, centering the logo at the bottom wouldn't be difficult. Regarding #2186, I'm not sure, but I think my docking station/dell monitors are causing the grey issue. When I disconnected and downloaded the images as normal on my Mac, I no longer had the grey overlay problem. But we can leave it open as there is no way for me to confirm what else it could be. |
as we discussed earlier today, i like the idea of moving the |
I can make whatever small changes to spacing/padding. |
let's just take out the |
Issue with extremely long URLs; they don't line wrap and the interfere with the watermark style right-aligned logo http://localhost:3000/exploredata?mls=1.cardiovascular_diseases-3.preventable_hospitalizations-5.06&mlp=comparevars&group1=Black.NH&group2=A%7ENHPI.NH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Description
This PR adds the HET logo-text and removes unnecessary elements when taking screenshots.
exploredata/
url with params to the bottom of the screenshot using thehtml2Canvas
libraryelementsToHide
prop to CardWrapper to hide a list of elements when capturing the chart image.Motivation and Context
Has this been tested? How?
Tested locally
Screenshots (if appropriate):
Types of changes
Post-merge TODO
I have inspected frontend changes and run affected data pipelines:
Any target user persona(s)?
Preview link below in Netlify comment 😎