Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save Image" menu option gets unwanted gray boxing on 2nd monitor #2186

Closed
benhammondmusic opened this issue May 12, 2023 · 0 comments · Fixed by #3700
Closed

"Save Image" menu option gets unwanted gray boxing on 2nd monitor #2186

benhammondmusic opened this issue May 12, 2023 · 0 comments · Fixed by #3700
Assignees
Labels
bug Something isn't working frontend help-wanted great first issue or place to start for our open source community members vega

Comments

@benhammondmusic
Copy link
Collaborator

benhammondmusic commented May 12, 2023

Describe the bug
Occasionally the screenshots have been coming out with slightly odd results, some or all of the following:

  • greyed border
  • image distortions, etc.
  • legend font is serif on screenshot but should be sans serif like on the real tracker

It's been hard to reproduce, but let's document stuff here as it's found and then address.

Edit: on ben's machine, it seems to only occur:

  • when laptop is plugged into a larger monitor
  • when the browser is opened on that larger monitor
  • in Safari
  • on the Vega bar charts or D3 time charts

There is an issue opened on the screenshot package mentioning a conflict when the screenshot content is wrapped in a material ui <Paper> component vre2h/use-react-screenshot#56

Things tried that didn't help:

  • exporting as jog instead of png
  • wrapping entire card in <Paper>
  • removing the MUI provider at the top level
  • It's possible this is being caused by the <Backdrop> component that greys out the backdrop and focuses the user on a spinner while the screenshot is thinking.... perhaps on some machines the grayed background is interfering

Example of weirdness

Evan - probably Windows / Edge?
image

@benhammondmusic benhammondmusic added the bug Something isn't working label May 12, 2023
@benhammondmusic benhammondmusic self-assigned this May 12, 2023
@benhammondmusic benhammondmusic moved this to 🐛 Bugs in HET Board May 12, 2023
@eriwarr eriwarr self-assigned this Jul 17, 2023
@benhammondmusic benhammondmusic changed the title Screenshot occasionally getting weird results "Save Image" menu option gets unwanted gray boxing on 2nd monitor Feb 2, 2024
@benhammondmusic benhammondmusic added frontend vega help-wanted great first issue or place to start for our open source community members labels Feb 2, 2024
@github-project-automation github-project-automation bot moved this from 🐛 Bugs to Closed in HET Board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend help-wanted great first issue or place to start for our open source community members vega
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants