Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant code and other refactoring #193

Merged
merged 9 commits into from
Jan 4, 2023
Merged

Removed redundant code and other refactoring #193

merged 9 commits into from
Jan 4, 2023

Conversation

bharathkalyans
Copy link
Contributor

@bharathkalyans bharathkalyans commented Jan 2, 2023 •
edited by SaptarshiSarkar12
Loading

  1. Worked on Drifty_CLI, CreateLogs, FileLoader and ProgressBarThread.
  2. Created package for the utility functions which were extracted from Drifty_CLI file.
  3. Moved the HardCoded strings to DriftyConstant file.
  4. Created Singletons for the Scanner class and CreateLogs file.

@netlify
Copy link

netlify bot commented Jan 2, 2023 •
edited
Loading

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 168f17f
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/63b43cb1e67778000878d5bb
😎 Deploy Preview https://deploy-preview-193--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bharathkalyans
Copy link
Contributor Author

Hi @SaptarshiSarkar12, I accidentally closed yesterdays PR, so had to open a new one. I have made the changes as requested.

@SaptarshiSarkar12
Copy link
Owner

@bharathkalyans Please create a GitHub issue describing the changes that you want to make and link that with this PR.

@SaptarshiSarkar12
Copy link
Owner

I shall review it tomorrow. @bharathkalyans . Let me know when you have made the issue.

@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Resolved Issues Removed redundant code and other refactoring Jan 2, 2023
@bharathkalyans
Copy link
Contributor Author

@bharathkalyans
Copy link
Contributor Author

Created the issue and linked to it.

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Jan 2, 2023 that may be closed by this pull request
Remove Redundant Code and Do Refactoring of the Code base #194
Closed
@SaptarshiSarkar12
Copy link
Owner

Created the issue and linked to it.

Great @bharathkalyans 👍 ! Shall review it tomorrow.

@bharathkalyans
Copy link
Contributor Author

The codebase still needs a lot of refactoring, renaming of the Class variables and stuff like that.Will look into it I once I am free!

SaptarshiSarkar12
SaptarshiSarkar12 requested changes Jan 3, 2023
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkalyans Please make the requested changes and then, I shall approve this PR.

src/Drifty_CLI.java Outdated Show resolved Hide resolved
src/Drifty_CLI.java Outdated Show resolved Hide resolved
src/Drifty_CLI.java Outdated Show resolved Hide resolved
src/CheckDirectory.java Outdated Show resolved Hide resolved
src/CheckDirectory.java Outdated Show resolved Hide resolved
@SaptarshiSarkar12
Copy link
Owner

The codebase still needs a lot of refactoring, renaming of the Class variables and stuff like that.Will look into it I once I am free!

That's great. You may do so.

bharathkalyans and others added 5 commits January 3, 2023 20:02
@bharathkalyans @SaptarshiSarkar12
Update src/CheckDirectory.java
3185dc4 
Co-authored-by: Saptarshi Sarkar <[email protected]>
@bharathkalyans @SaptarshiSarkar12
Update src/Drifty_CLI.java
99002d1 
Co-authored-by: Saptarshi Sarkar <[email protected]>
@bharathkalyans @SaptarshiSarkar12
Update src/CheckDirectory.java
f2f2d84 
Co-authored-by: Saptarshi Sarkar <[email protected]>
@bharathkalyans @SaptarshiSarkar12
Update src/Drifty_CLI.java
176af19 
Co-authored-by: Saptarshi Sarkar <[email protected]>
@bharathkalyans @SaptarshiSarkar12
Updated src/Drifty_CLI.java
168f17f 
Co-authored-by: Saptarshi Sarkar <[email protected]>
@bharathkalyans
Copy link
Contributor Author

@bharathkalyans Please make the requested changes and then, I shall approve this PR.

Done with the changes 👍🏼

@SaptarshiSarkar12
Copy link
Owner

@bharathkalyans Please make the requested changes and then, I shall approve this PR.

Done with the changes 👍🏼

Great!

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge 👍
Thanks for contributing 🚀 🚀 🚀 !!
@bharathkalyans If you liked contributing to the project, please leave a star ⭐ . You may join our Discord server for the project's discussions - https://discord.gg/DeT4jXPfkG

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit d4573b6 into SaptarshiSarkar12:master Jan 4, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition App 💻 Issues/Pull Requests which update Drifty Application Code labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #193 from bharathkalyans/code-review-and-refactoring
cbb136f 
Removed redundant code and other refactoring
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #193 from bharathkalyans/code-review-and-refactoring
bd908d7 
Removed redundant code and other refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code feature ✨ New feature request or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Redundant Code and Do Refactoring of the Code base
2 participants
@bharathkalyans @SaptarshiSarkar12