Merge pull request #193 from bharathkalyans/code-review-and-refactoring

Removed redundant code and other refactoring

Website/script.js

@@ -13,8 +13,8 @@ fetch(
   });
 
 function download_alert_window() {
-  var w = confirm("Do you want to download Drifty?");
-  if (w == true) {
+  let w = confirm("Do you want to download Drifty?");
+  if (w === true) {
     alert("Thanks for Downloading");
     window.open(
       "https://github.com/SaptarshiSarkar12/Drifty/releases/latest/download/Drifty_CLI.exe"
@@ -25,8 +25,8 @@ function download_alert_window() {
 }
 
 function download_alert_apple() {
-  var a = confirm("Do you want to download Drifty?");
-  if (a == true) {
+  let a = confirm("Do you want to download Drifty?");
+  if (a === true) {
     alert("Thanks for Downloading");
     window.open(
       "https://github.com/SaptarshiSarkar12/Drifty/releases/latest/download/Drifty.jar"
@@ -248,7 +248,7 @@ function toggleMore(btn, id) {
 function renderAssets(assets) {
   return assets.reduce((all, asset) => {
     //check if it is for windows
-    let is_windows = asset.name.split(".").pop().toLocaleLowerCase() == "exe";
+    let is_windows = asset.name.split(".").pop().toLocaleLowerCase() === "exe";
 
     if (is_windows) {
       return `${all} <a href="${asset.browser_download_url}">Download <i class="fab fa-windows"></i></a>`;

src/CheckDirectory.java

@@ -4,6 +4,8 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 
+import static constants.DriftyConstants.*;
+
 /**
  * This class checks if a directory exists or not. if it doesn't, the directory is created.
  */
@@ -14,10 +16,10 @@ class CheckDirectory {
      * @throws IOException when creating the directory fails.
      */
     CheckDirectory(String dir) throws IOException {
-        if (!(checkIfFolderExists(dir))){
+        if (!(checkIfFolderExists(dir))) {
             Path directory = FileSystems.getDefault().getPath(dir);
             Files.createDirectory(directory);
-            Drifty_CLI.logger.log("INFO", "Directory Created");
+            Drifty_CLI.logger.log(LOGGER_INFO, DIRECTORY_CREATED);
         }
     }
 
@@ -34,8 +36,8 @@ private static boolean checkIfFolderExists(String folderName) {
                 found = true;
             }
         } catch (Exception e) {
-            System.out.println("Error while checking for directory !");
-            Drifty_CLI.logger.log("ERROR", "Error while checking for directory !");
+            System.out.println(ERROR_WHILE_CHECKING_FOR_DIRECTORY);
+            Drifty_CLI.logger.log(LOGGER_ERROR, ERROR_WHILE_CHECKING_FOR_DIRECTORY);
         }
         return found;
     }

src/DownloaderThread.java

@@ -5,15 +5,15 @@
 import java.nio.channels.Channels;
 import java.nio.channels.ReadableByteChannel;
 
-public class DownloaderThread extends Thread{
+public class DownloaderThread extends Thread {
 
-    private URL url;
-    private FileOutputStream file;
-    private long start;
-    private long end;
+    private final URL url;
+    private final long start;
+    private final long end;
+    private final FileOutputStream file;
 
     public DownloaderThread(URL url, FileOutputStream file, long start, long end) {
-        this.url=url;
+        this.url = url;
         this.file = file;
         this.start = start;
         this.end = end;
@@ -24,7 +24,7 @@ public void run() {
         ReadableByteChannel readableByteChannel;
         try {
             URLConnection con = url.openConnection();
-            con.setRequestProperty("Range", "bytes="+start+"-"+end);
+            con.setRequestProperty("Range", "bytes=" + start + "-" + end);
             con.connect();
             readableByteChannel = Channels.newChannel(con.getInputStream());
             file.getChannel().transferFrom(readableByteChannel, 0, Long.MAX_VALUE);