Merge cockroachdb#107439

107439: roachprod-microbench: fix delta string parsing r=renatolabs a=herkolategan A microbenchmark run, ran into an unexpected value for the delta string produced by the perf package. This change adds the "?" case so that all other values can be parsed correctly. Release note: None Epic: None Co-authored-by: Herko Lategan <[email protected]>
Santamaura · Jul 25, 2023 · 3b2c035 · 3b2c035
2 parents 8551d57 + c9eed3e
commit 3b2c035
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/cmd/roachprod-microbench/google/service.go b/pkg/cmd/roachprod-microbench/google/service.go
@@ -212,7 +212,7 @@ func (srv *Service) createRawSheet(
 			vals = append(vals, numCell(entry.Summaries[run].Center))
 		}
 		delta := comparison.FormattedDelta
-		if delta == "~" {
+		if delta == "~" || delta == "?" {
 			vals = append(vals, strCell(delta))
 		} else {
 			vals = append(vals, percentCell(deltaToNum(delta)))