Skip to content

Commit

Permalink
roachprod-microbench: fix delta string parsing
Browse files Browse the repository at this point in the history
A microbenchmark run, ran into an unexpected value for the delta string produced
by the perf package. This change adds the "?" case so that all other values can
be parsed correctly.

Release note: None
Epic: None
  • Loading branch information
herkolategan committed Jul 24, 2023
1 parent c9fdac0 commit c9eed3e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/roachprod-microbench/google/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func (srv *Service) createRawSheet(
vals = append(vals, numCell(entry.Summaries[run].Center))
}
delta := comparison.FormattedDelta
if delta == "~" {
if delta == "~" || delta == "?" {
vals = append(vals, strCell(delta))
} else {
vals = append(vals, percentCell(deltaToNum(delta)))
Expand Down

0 comments on commit c9eed3e

Please sign in to comment.