Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Finnish localization #103

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

minna-xD
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add Finnish translation

Featured Covered in this PR

  • Creating app_fi.arb file and translating strings based on English file
  • Adding fi locale in app.dart

Related Tickets & Documents

Screenshots, Recordings

Tested Feature??

  • In Real Device.
  • In Emulator

Translation is ready but I'm having trouble running the project for review (I'm a complete newbie in the Flutter etc. world so I didn't have a dev environment installed before). I'll try looking into this more because it would be useful to check string lengths at least.

Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing

@SankethBK SankethBK merged commit 1c7effc into SankethBK:master Oct 21, 2023
@minna-xD
Copy link
Contributor Author

I succeeded in launching the app in an emulator today. Finnish is looking good. Hurraah! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants