Moving pad locations to field constants. Updated stolen boosts logic. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boost steals are now better calculated using the pad label rather than player location heuristic.
|
✅ Build carball 0.6.18-bgvlwbao completed (commit 222431458a by @IsaacLance) |
1 similar comment
|
✅ Build carball 0.6.18-bgvlwbao completed (commit 222431458a by @IsaacLance) |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 89.87% 89.97% +0.09%
==========================================
Files 98 98
Lines 4318 4320 +2
Branches 740 742 +2
==========================================
+ Hits 3881 3887 +6
+ Misses 323 317 -6
- Partials 114 116 +2 |
dtracers
reviewed
Nov 12, 2019
| big = cls.field_constants.get_big_pads() | ||
| # Get big pads below or above 0 depending on team | ||
| if is_orange: | ||
| opponent_pad_labels = big[big[:, 1] < 0][:, 2] |
There was a problem hiding this comment.
can you add a bit more detailed explanation of how this logic works?
It is a bit hard to read
|
✅ Build carball 0.6.18-sqrsrpas completed (commit 68bec4bbe5 by @IsaacLance) |
1 similar comment
|
✅ Build carball 0.6.18-sqrsrpas completed (commit 68bec4bbe5 by @IsaacLance) |
|
✅ Build carball 0.6.19-xnabpenp completed (commit 5c25b23e63 by @dtracers) |
1 similar comment
|
✅ Build carball 0.6.19-xnabpenp completed (commit 5c25b23e63 by @dtracers) |
dtracers
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.