Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session bridge changes from #1159 to release-2.7.x #1163

Closed
wants to merge 26 commits into from
Closed

Add session bridge changes from #1159 to release-2.7.x #1163

wants to merge 26 commits into from

Conversation

shethj
Copy link
Collaborator

@shethj shethj commented May 1, 2023

Add session bridge changes from #1159 to release-2.7.x

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

bendvc and others added 26 commits March 3, 2023 17:00
@bendvc @adamraya @vmarta
Update develop with release-v2.7.0 (#1033)
b638ce5 
* Starting release process for 2.7.0

* Update Create MRT credentials file (#1025)

* Release 2.7: fix order of hooks (#1027)

* Return early only after all of the hooks are called

* Bumper version

---------

Co-authored-by: Ben Chypak <[email protected]>

* Quick fix for einstein data (#1028)

* Quick fix for einstein data

* Bump Version

* Re-lock package-lock files with npm 8

* Update package-lock.json

* Update einstein.js

* Regenerate lock files (#1030)

* Regenerate lock files

* Bump version to 2.7.0-alpha.3

* Bump to 2.7.0 (#1032)

* Begin development on 2.8.0

---------

Co-authored-by: Adam Raya <[email protected]>
Co-authored-by: Vincent Marta <[email protected]>
Move the MRT reference app to the SDKs, so that we can verify eg. Nod…
a402f66 
…e support (#966)
@echessman @bendvc
BUG: Changed type of the phone number field to bring up numberic keyb…
5cf7c06 
…oard on mobile devices - W-9871940 (#1016)

Co-authored-by: Ben Chypak <[email protected]>
@johnboxall @rsexton404
Update Retail React App Page Designer integration README (#1041)
ddf5805 
Co-authored-by: Richard Sexton <[email protected]>
@wjhsf
Implement updateCustomerPassword as no-op. (#1031)
246d484
@wjhsf
Allow query hook parameters to be null. (#1046)
fc789fe 
* Remove unused util.

* Allow query hook parameters to be `null`.
@wjhsf
Fix addresses not having preferred address first. (#1051)
c72bb52 
* Fix addresses not having preferred address first.

* Include all addresses, not just preferred address twice.

* Correctly include preferred address.
@bendvc
Make mergeBasket Conditional More Robust (#1048)
cf008cb 
* Update merge logic

* Update CHANGELOG.md

* Lint

* PR feedback

* Rename isNewlyRegisters to isNew for simplicity

* Lint
@kevinxh @wjhsf
[commerce-sdk-react] Decode pre-fetched token and save auth data in s…
92c156e 
…torage (#1052)

* add test

* decode jwt data

* lint

* Update packages/commerce-sdk-react/src/auth/index.ts

Co-authored-by: Will Harney <[email protected]>

* rename parseSlasJWT

* Update packages/commerce-sdk-react/src/auth/index.test.ts

Co-authored-by: Will Harney <[email protected]>

* convert all .thens to await

* make fake token in tests more clear

* lint

---------

Co-authored-by: Will Harney <[email protected]>
@vmarta @alexvuong
Prevent modal to open when it fails to add an item to cart (#1053)
9f3bc9e 
* prevent modal to open when it fails to add an item to cart

* Update comment

---------

Co-authored-by: Alex Vuong <[email protected]>
@bendvc
Fix getConfig referencing config from incorrect location (#1049)
a6c535b 
* Initial Commit

* Update CHANGELOG.md

* Revert some testing code

* Get test coverage back up

* Test build directory folder before proceeding.
@breadadams @bendvc
fix(template-retail-react-app): product-list refinements (#957)
cd4e64f 
* fix(template-retail-react-app): product-list refinements

+ Ensure that the `selectedFilters` provided to the `Refinements` value components is always an array. And update said value components (checkbox, color, radio & size) to handle always receiving an array.
+ Apply some loose equality checks, catering for cases where a refinement URL param is parsed as a number but the refinement `.value` is a stringified number.
+ Fix bug where non-multiple filters could not be unchecked by selecting themselves (e.g. clicking an already checked checkbox).
+ Fix bug where a refinement URL param is parsed as a number, but was handled as a string (with `.split()`).
+ Fix bug where radio refinements would still appear as checked after clearing the value via `SelectedRefinements`.
+ Deprecate unused proptypes in `SizeRefinements`

* feat(retail-react-app): update `CheckboxRefinements`

+ Adjust the `onChange` logic so that multiple checkbox refinements can be selected

---------

Co-authored-by: Ben Chypak <[email protected]>
@clavery @wjhsf @adamraya
update docs for shopper-experience scope (#1059)
918f4e5 
* add docs for experience scope

* Add `merge_group` event to trigger GA builds

---------

Co-authored-by: Will Harney <[email protected]>
Co-authored-by: Adam Raya Navarro <[email protected]>
@wjhsf
Update lockfiles to reflect current version. (#1071)
1acbf8f
@adamraya @wjhsf
[commerce-sdk-react] Implement remaining Shopper Baskets cache logic (#…
b11a91a 
…1070)

* Refactor Shopper Basket cache following new pattern

* Fix types

* Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/cache.ts

Co-authored-by: Will Harney <[email protected]>

* PR Feedback

* Clean up unused utils and types after refactor

* Add missing response basketId to queryKey

* Implement cache for the remaining mutations

* Tests WIP

* PR Feedback & Use query key path in `deleteBasket` cache

* Add tests for mutations returning void response

* PR Feedback

* Remove unused `and` hooks util

* Revert "Remove unused `and` hooks util"

This reverts commit c0a364a.

---------

Co-authored-by: Will Harney <[email protected]>
@adamraya
[commerce-sdk-react] Fix Shopper Baskets Test case (#1082)
199e80f 
* Fix Shopper Basket empty response test cases

* lint
@ecRobertEngel @wjhsf
feat(pwa-kit-dev): minor performance improvements and added comments (#…
6f45b3b 
…974)

* feat(pwa-kit-dev): minor performance improvements and added comments

* docs(pwa-kit-dev): clean up comments

* refactor(pwa-kit-dev): update condition from PR feedback

---------

Co-authored-by: Will Harney <[email protected]>
@wjhsf
Update dependencies. (#1079)
3879413 
* Remove internal packages to bypass lerna nonsense.

Include output.json to make restoring deps easier.

* Disable build scripts to make changing deps easier.

* Update root deps.

* Fix typescript issue.

* Create restore script to restore internal deps/scripts.

* Update commerce-sdk-react deps.

* Update test-commerce-sdk-react deps.

* Update template-typescript-minimal deps

* Improve restore script.

* Fix trailing comma.

* Update template-retail-react-app deps

* npm prune everything

* Update pwa-kit-runtime deps

* Update pwa-kit-react-sdk deps

* Update pwa-kit-create-app deps

* Update pwa-kit-dev deps (except eslint)

* Update pwa-kit-dev eslint deps

* Update internal-lib-build deps (except eslint)

* Update pwa-kit eslint deps

* Restore internal deps.

* Restore build scripts.

* Remove temporary helper files.

* Bump ua-parser-js to avoid vulnerable version.

* Anchor cross-env common dep to version used by internal-lib-build.

* Re-enable eslint.
@bendvc @wjhsf @adamraya
Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orde…
fb15f77 
…rs) (#1073)

* Initial commit

* Update packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

Co-authored-by: Will Harney <[email protected]>

* Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts

Co-authored-by: Will Harney <[email protected]>

* Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts

Co-authored-by: Will Harney <[email protected]>

* Added root to all query keys, use remove over clear

* Remove previous impemented "clear" from utils

* Initial tests for shoppercontexts

* Update ShopperLogin tests

* Fix order tests

* Update packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts

Co-authored-by: Will Harney <[email protected]>

* Update cache.ts

* Lint!

* Update Json.tsx

* Lint!

* Testing race condition in tests

* Re-add tests in other order.

* Update CHANGELOG.md

* Add todo to complete context cache work

* Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/mutation.test.ts

Co-authored-by: Will Harney <[email protected]>

* Update packages/commerce-sdk-react/src/components/ShopperExperience/Page/index.tsx

Co-authored-by: Will Harney <[email protected]>

* Update useAuthHelper.ts

* Update packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts

Co-authored-by: Adam Raya <[email protected]>

---------

Co-authored-by: Will Harney <[email protected]>
Co-authored-by: Adam Raya <[email protected]>
@sandragolden
remove site alias and locale from location.state.directedFrom path (#…
6b9d436 
…1065)

* remove site alias and locale from location.state.directedFrom path

* moving call to removeSiteLocaleFromPath into use-navigation hook

* fixing failing test, added tests for removeSiteLocaleFromPath

* per code review, skipping failed test instead of using mocking
@adamraya @bendvc
Fix Page Designer ImageWithText Link component (#1092)
00ff2bd 
* Fix PD ImageWithText Link component by using Chakra UI Link

* Use isAbsoluteURL to use react-router Link or Chakra Link component

* PR Feedback

* Clean up

* Update packages/template-retail-react-app/app/page-designer/assets/image-with-text/index.jsx

Co-authored-by: Ben Chypak <[email protected]>

* Remove temporal page-viewer page to facilitate review

---------

Co-authored-by: Ben Chypak <[email protected]>
@kevinxh
split ssr build on local (#1155)
a0d322a
@kevinxh
add suffix to ssr build files (#1157)
ebb3a03
@shethj
Added session bridge call to login for phased launch
dc9058c
@shethj
Merge branch 'develop' into add-session-bridge-phased-launch
c43419f
@shethj
Fix code smell for session-bridge in hybrid
da08f53
@shethj shethj requested a review from a team as a code owner May 1, 2023 20:50
@vcua-mobify
Copy link
Collaborator

I think other changes from the develop branch have been included in this PR, which is why we're seeing a lot of file changes.

@shethj shethj closed this May 1, 2023
@shethj shethj deleted the add-session-bridge-phased-launch branch May 1, 2023 20:57
@shethj shethj restored the add-session-bridge-phased-launch branch May 1, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.