Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) #1073

bendvc · 2023-03-20T23:16:27Z

Description

This PR implements the remaining cache matrix actions for the API's mentioned in the title. To fulfill the issues requirements it was necessary to add the cache matrix functionality to the auth helpers code as it wasn't present previously.

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Changes

(change1)

How to Test-Drive This PR

Add cache matrix actions for shopper context.
Add remaining cache matrix action for shopper customer.
Add remaining cache matrix action for shopper orders.
Implement cache matrix for auth helpers and add clear cache feature.
Update test app for validating this work.

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

TODO

Added invalidation on context changes (ticket)

bendvc · 2023-03-20T23:18:40Z

packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts

+    createShopperContext(customerId, {parameters}) {
+        return {
+            invalidate: [{queryKey: getShopperContext.queryKey(parameters)}]
+        }
+    },
+    updateShopperContext(_customerId, {parameters}, response) {
+        return {
+            update: [
+                {
+                    queryKey: getShopperContext.queryKey(parameters),
+                    updater: (): ShopperContextsTypes.ShopperContext | undefined => ({...response})
+                }
+            ]
+        }
+    },
+    deleteShopperContext(_customerId, {parameters}) {
+        return {
+            remove: [{
+                queryKey: getShopperContext.queryKey(parameters)
+            }]
+        }
+    }


Shopper context is a special exception to how all the other endpoints work. Essentially you are manipulating a singleton on the backend, your context.

One interesting side effect of the work her is that if you create the context singleton and then delete it, if you have an active hook to get the context it will run after the deletion and get a 404. I'm still investigating why this is happening, but could use some input.

bendvc · 2023-03-20T23:19:18Z

packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts

-    deleteCustomerProductList: TODO('deleteCustomerProductList'),
+    deleteCustomerProductList(customerId, {parameters}) {
+        return {
+            // TODO: Rather than invalidate, can we selectively update?


You might see these todo's left around, they are simply copied and pasted but for the most part are still valid for future cache work.

Aside: I think we should not do this selective updates in the future.

I've tried doing it in one of my PRs last time. But I reverted the change, as the logic became complex and error-prone in my experience.

Take a read of this article from one of the core maintainers of react-query. He suggested to prefer invalidation over direct updates (which is similar to "selective updates" in our terminology), because invalidation is safer and simpler approach.

@vmarta I had the exact same thought as your suggestion, I previously said that

invalidation is a must have and selective updates are nice to haves

But later Alex found out an issue that made me think twice about the statement. The reason being that in SCAPI land, the models are used interchangeably across different API endpoints. For example, you get shopper's baskets from ShopperCustomer API as oppose to ShopperBasket API, but you mutate the baskets using ShopperBasket API. This creates dependencies between queries. For example, it's common that we have the following hooks on a page

basket mutation: addToCart

customer query: getCustomerBaskets

When the mutation happens, if we don't update, but only invalidate, we run into a situation that we don't have access to the invalidation fetch call, so loading state is broken for all mutations.

I'm not sure if there is another way to solve this, selective updates seems like the obvious solution...

bendvc · 2023-03-20T23:21:30Z

packages/commerce-sdk-react/src/hooks/types.ts

@@ -192,6 +192,7 @@ export type CacheUpdate = {
    update?: CacheUpdateUpdate<unknown>[]
    invalidate?: CacheUpdateInvalidate[]
    remove?: CacheUpdateRemove[]
+    clear?: boolean


This is a new cache update action. If this is set to true, the entire cache is cleared. It was necessary to do this here as there was no access to the queryClient elsewhere (like the updater function).

bendvc · 2023-03-20T23:22:34Z

packages/commerce-sdk-react/src/hooks/utils.ts

+
+    if (cacheUpdates.clear) {
+        queryClient.clear()
+    }


This action intentionally happens after all the others if for some reason there are other updater actions defined alongside of the clear action, which shouldn't ever be the case.

bendvc · 2023-03-20T23:23:30Z

packages/test-commerce-sdk-react/app/components/Json.tsx

+import React, {useState} from 'react'

-const Json = React.memo(({data}: {data: any}) => (
-    <div>
-        <pre>{JSON.stringify(data, null, 2)}</pre>
-    </div>
-))
+const Json = ({data}: {data: any}) => {
+    const [expanded, setExpanded] = useState(false)
+
+    const style = {
+        body: {
+            position: 'relative',
+            height: expanded ? 'inherit' : '100px',
+            overflow: 'hidden'
+        },
+        button: {
+            position: 'absolute',
+            right: 0,
+            paddingRight: 10
+        },
+        shadow: {
+            position: 'absolute',
+            bottom: 0,
+            left: 0,
+            width: '100%',
+            height: 10,
+            background:
+                'linear-gradient(to bottom, rgba(137,255,241,0) 0%,rgba(255,255,255,1) 100%)'
+        }
+    }
+    return (
+        <div style={style.body}>
+            <a style={style.button} onClick={() => setExpanded(!expanded)}>
+                {expanded ? '[-]' : '[+]'}
+            </a>


I was tired of scrolling through all the response objects. This made things less infuriating. 🤣

bendvc · 2023-03-20T23:28:13Z

packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

@wjhsf I was able to scratch something together for the cache matrix in the auth helpers. I'll defo need your feedback on all the typescriptisms.

Looks ace! 🙌

wjhsf

(See ❗ comment)

packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts

packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

wjhsf · 2023-03-21T15:17:53Z

packages/commerce-sdk-react/src/hooks/utils.ts

@@ -31,6 +31,10 @@ export const updateCache = (queryClient: QueryClient, cacheUpdates: CacheUpdate,
        // If an updater isn't given, fall back to just setting the data
        queryClient.setQueryData(queryKey, updater ?? data)
    )
+
+    if (cacheUpdates.clear) {
+        queryClient.clear()


❗ The query cache is a global state. If end users are using react query for their own cache management, this will wipe out their data, too.

Proposal: namespace our query keys (e.g. ['commerce-sdk-react', ...path, parameters]) and then do a remove that just matches our namespace (e.g. remove: {queryKey: ['commerce-sdk-react']}).

Adding a namespace is probably out of scope, here, but I think we can move in the right direction by doing remove with an empty array (I think that matches everything?). That would approximate clear, while setting us up to easily come back later and add the namespace.

Thats a very good call out. I wasn't thinking about custom hooks that are used outside of the hooks library. I did however think about using remove as a way to clear the cache using the /organizations/ query key partial. But had opted not to go that route was the implementation within react-query suggests that clear would be more performant. I believe remove will do batching and remove cache in chunks.

So 2 questions here:

Do we really care about how fast removing of the cache is? if you think about it, someone can just close their browser and leave all the cache in there anyway.

Should we care about unintentionally clearing cache that is outside of the commerce-sdk? I think the usecases are slim, but I suppose there are potential for wanting that behaviour. E.g. Someone has a react app that has a single click buy now button for a product, where it will login as a guest, add item to a cart, checkout, logout. We wouldn't want their external react query cache to be cleared in that case.

🤔

UPDATE: We decided to remove the "clear" functionality in favour of using "remove" since we don't want to effect any external cache since the client is potentially shared. Also, we added a namespace to all the cache keys to better avoid collisions.

wjhsf · 2023-03-21T15:28:06Z

packages/commerce-sdk-react/src/hooks/useAuthHelper.ts


 export const AuthHelpers = {
    LoginGuestUser: 'loginGuestUser',
    LoginRegisteredUserB2C: 'loginRegisteredUserB2C',
-    Logout: 'logout',
-    Register: 'register'


Why no more register?

I talked to @kevinxh about this. register doesn't exist in the helper namespace, so I reached out to Kev an he said I could delete it. It looks like it wasn't being used either.

Sorry, actually I was wrong! We are using the register method in the retail react app.

~~And register method was lost in the big previous refactor.~~

The register helper is special, because it is not a ShopperLogin method, but rather a ShopperCustomer method.

wjhsf · 2023-03-21T15:28:26Z

packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

Looks ace! 🙌

packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts

wjhsf · 2023-03-21T15:54:46Z

packages/test-commerce-sdk-react/app/pages/use-shopper-context.tsx

+} from 'commerce-sdk-react-preview'
+import Json from '../components/Json'
+
+const renderQueryHook = (name: string, {data, isLoading, error}: any) => {


I don't like any (but I recognize that this isn't a super important place to avoid it).

wjhsf · 2023-03-21T15:57:02Z

packages/test-commerce-sdk-react/app/pages/use-shopper-context.tsx

+                {queryHooks.map(({name, hook}) => {
+                    return renderQueryHook(name, {...hook})


Weird that name is destructured to a separate variable, but everything else is left in the hook object (and name not destructured in the mutations).

Co-authored-by: Will Harney <[email protected]>

…eCommerceCloud/pwa-kit into add-cache-update-logic

Co-authored-by: Will Harney <[email protected]>

packages/commerce-sdk-react/src/components/ShopperExperience/Page/index.tsx

wjhsf · 2023-03-23T20:06:59Z

packages/commerce-sdk-react/src/hooks/ShopperLogin/cache.ts

-    logoutCustomer: TODO('logoutCustomer'),
+    logoutCustomer: () => {
+        return {
+            remove: [{queryKey: ['/commerce-sdk-react']}]


Why a leading / in the namespace? Query keys are arbitrary, they don't necessarily need to look like paths!

I was only adapting to fit in here so it looks consistent. No other real reason. I figured we would address the cache keys eventually and we can look at it then.

packages/commerce-sdk-react/src/hooks/ShopperBaskets/mutation.test.ts

adamraya · 2023-03-24T19:49:02Z

packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts

+        }
+    },
+    updateShopperContext(_customerId, {parameters}) {
+        return {


Do we want to add a TODO as a reminder that we need to invalidate all the cache in case data stored in cache is affected by the changes to the context?

I added a TODO in a comment with a link to the ticket for the work. I chose not to use the TODO method since this work is follow up work and not a developer reminder before going GA

…test.ts Co-authored-by: Will Harney <[email protected]>

…age/index.tsx Co-authored-by: Will Harney <[email protected]>

…eCommerceCloud/pwa-kit into add-cache-update-logic

packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts

Co-authored-by: Adam Raya <[email protected]>

* Update `develop` with `release-v2.7.0` (#1033) * Starting release process for 2.7.0 * Update Create MRT credentials file (#1025) * Release 2.7: fix order of hooks (#1027) * Return early only after all of the hooks are called * Bumper version --------- Co-authored-by: Ben Chypak <[email protected]> * Quick fix for einstein data (#1028) * Quick fix for einstein data * Bump Version * Re-lock package-lock files with npm 8 * Update package-lock.json * Update einstein.js * Regenerate lock files (#1030) * Regenerate lock files * Bump version to 2.7.0-alpha.3 * Bump to 2.7.0 (#1032) * Begin development on 2.8.0 --------- Co-authored-by: Adam Raya <[email protected]> Co-authored-by: Vincent Marta <[email protected]> * Move the MRT reference app to the SDKs, so that we can verify eg. Node support (#966) * BUG: Changed type of the phone number field to bring up numberic keyboard on mobile devices - W-9871940 (#1016) Co-authored-by: Ben Chypak <[email protected]> * Update Retail React App Page Designer integration README (#1041) Co-authored-by: Richard Sexton <[email protected]> * Implement `updateCustomerPassword` as no-op. (#1031) * Allow query hook parameters to be `null`. (#1046) * Remove unused util. * Allow query hook parameters to be `null`. * Fix addresses not having preferred address first. (#1051) * Fix addresses not having preferred address first. * Include all addresses, not just preferred address twice. * Correctly include preferred address. * Make `mergeBasket` Conditional More Robust (#1048) * Update merge logic * Update CHANGELOG.md * Lint * PR feedback * Rename isNewlyRegisters to isNew for simplicity * Lint * [commerce-sdk-react] Decode pre-fetched token and save auth data in storage (#1052) * add test * decode jwt data * lint * Update packages/commerce-sdk-react/src/auth/index.ts Co-authored-by: Will Harney <[email protected]> * rename parseSlasJWT * Update packages/commerce-sdk-react/src/auth/index.test.ts Co-authored-by: Will Harney <[email protected]> * convert all .thens to await * make fake token in tests more clear * lint --------- Co-authored-by: Will Harney <[email protected]> * Prevent modal to open when it fails to add an item to cart (#1053) * prevent modal to open when it fails to add an item to cart * Update comment --------- Co-authored-by: Alex Vuong <[email protected]> * Fix `getConfig` referencing config from incorrect location (#1049) * Initial Commit * Update CHANGELOG.md * Revert some testing code * Get test coverage back up * Test build directory folder before proceeding. * fix(template-retail-react-app): product-list refinements (#957) * fix(template-retail-react-app): product-list refinements + Ensure that the `selectedFilters` provided to the `Refinements` value components is always an array. And update said value components (checkbox, color, radio & size) to handle always receiving an array. + Apply some loose equality checks, catering for cases where a refinement URL param is parsed as a number but the refinement `.value` is a stringified number. + Fix bug where non-multiple filters could not be unchecked by selecting themselves (e.g. clicking an already checked checkbox). + Fix bug where a refinement URL param is parsed as a number, but was handled as a string (with `.split()`). + Fix bug where radio refinements would still appear as checked after clearing the value via `SelectedRefinements`. + Deprecate unused proptypes in `SizeRefinements` * feat(retail-react-app): update `CheckboxRefinements` + Adjust the `onChange` logic so that multiple checkbox refinements can be selected --------- Co-authored-by: Ben Chypak <[email protected]> * update docs for shopper-experience scope (#1059) * add docs for experience scope * Add `merge_group` event to trigger GA builds --------- Co-authored-by: Will Harney <[email protected]> Co-authored-by: Adam Raya Navarro <[email protected]> * Update lockfiles to reflect current version. (#1071) * [commerce-sdk-react] Implement remaining Shopper Baskets cache logic (#1070) * Refactor Shopper Basket cache following new pattern * Fix types * Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/cache.ts Co-authored-by: Will Harney <[email protected]> * PR Feedback * Clean up unused utils and types after refactor * Add missing response basketId to queryKey * Implement cache for the remaining mutations * Tests WIP * PR Feedback & Use query key path in `deleteBasket` cache * Add tests for mutations returning void response * PR Feedback * Remove unused `and` hooks util * Revert "Remove unused `and` hooks util" This reverts commit c0a364a. --------- Co-authored-by: Will Harney <[email protected]> * [commerce-sdk-react] Fix Shopper Baskets Test case (#1082) * Fix Shopper Basket empty response test cases * lint * feat(pwa-kit-dev): minor performance improvements and added comments (#974) * feat(pwa-kit-dev): minor performance improvements and added comments * docs(pwa-kit-dev): clean up comments * refactor(pwa-kit-dev): update condition from PR feedback --------- Co-authored-by: Will Harney <[email protected]> * Update dependencies. (#1079) * Remove internal packages to bypass lerna nonsense. Include output.json to make restoring deps easier. * Disable build scripts to make changing deps easier. * Update root deps. * Fix typescript issue. * Create restore script to restore internal deps/scripts. * Update commerce-sdk-react deps. * Update test-commerce-sdk-react deps. * Update template-typescript-minimal deps * Improve restore script. * Fix trailing comma. * Update template-retail-react-app deps * npm prune everything * Update pwa-kit-runtime deps * Update pwa-kit-react-sdk deps * Update pwa-kit-create-app deps * Update pwa-kit-dev deps (except eslint) * Update pwa-kit-dev eslint deps * Update internal-lib-build deps (except eslint) * Update pwa-kit eslint deps * Restore internal deps. * Restore build scripts. * Remove temporary helper files. * Bump ua-parser-js to avoid vulnerable version. * Anchor cross-env common dep to version used by internal-lib-build. * Re-enable eslint. * Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) (#1073) * Initial commit * Update packages/commerce-sdk-react/src/hooks/useAuthHelper.ts Co-authored-by: Will Harney <[email protected]> * Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts Co-authored-by: Will Harney <[email protected]> * Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts Co-authored-by: Will Harney <[email protected]> * Added root to all query keys, use remove over clear * Remove previous impemented "clear" from utils * Initial tests for shoppercontexts * Update ShopperLogin tests * Fix order tests * Update packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts Co-authored-by: Will Harney <[email protected]> * Update cache.ts * Lint! * Update Json.tsx * Lint! * Testing race condition in tests * Re-add tests in other order. * Update CHANGELOG.md * Add todo to complete context cache work * Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/mutation.test.ts Co-authored-by: Will Harney <[email protected]> * Update packages/commerce-sdk-react/src/components/ShopperExperience/Page/index.tsx Co-authored-by: Will Harney <[email protected]> * Update useAuthHelper.ts * Update packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts Co-authored-by: Adam Raya <[email protected]> --------- Co-authored-by: Will Harney <[email protected]> Co-authored-by: Adam Raya <[email protected]> * remove site alias and locale from location.state.directedFrom path (#1065) * remove site alias and locale from location.state.directedFrom path * moving call to removeSiteLocaleFromPath into use-navigation hook * fixing failing test, added tests for removeSiteLocaleFromPath * per code review, skipping failed test instead of using mocking * Fix Page Designer ImageWithText Link component (#1092) * Fix PD ImageWithText Link component by using Chakra UI Link * Use isAbsoluteURL to use react-router Link or Chakra Link component * PR Feedback * Clean up * Update packages/template-retail-react-app/app/page-designer/assets/image-with-text/index.jsx Co-authored-by: Ben Chypak <[email protected]> * Remove temporal page-viewer page to facilitate review --------- Co-authored-by: Ben Chypak <[email protected]> * split ssr build on local (#1155) * add suffix to ssr build files (#1157) * Added session bridge call to login for phased launch (#1159) * Added session bridge call to login for phased launch * Fix code smell for session-bridge in hybrid * Fix multi-value query params being lost (#1150) * Fix multi-value query params being lost * Update CHANGELOG.md * Snyk dependency updates (#1169) * Dependency updates * Update runtime package lock * Bump cosmiconfig version to latest * [Hybrid] PWA Kit should have a mechanism for replacing the access token when a SFRA login state is changed (#1171) * Implement mechanism to store refresh token copy and compare with sfra * Update tests and mocks for util function to check SFRA login state * Fix linting issues * FIx param types for util functionn * Rename old isTokenValid to isTokenExpired * Remove expiry for refresh_token in localstorage * Update packages/template-retail-react-app/app/commerce-api/utils.js Co-authored-by: Kevin He <[email protected]> * fix test * Fix linting on use-auth-modal.test.js * Update hasSFRAStateChanged logic to compare keys and values * Fix linting --------- Co-authored-by: Kevin He <[email protected]> * Add a redirect to login page after user signs out from checkout page (#1172) * Add a redirect to login page after user signs out from checkout page * Update CHANGELOG.md * Remove history since navigate handles similarly * Bump version number to 2.7.1-alpha.0 * Update changelogs * #1174 Replace invalid value for wrap property (#1179) * Update changelogs * Version bump to 2.7.1-preview.0 * Revert "Version bump to 2.7.1-preview.0" This reverts commit 985a7e0. * Update CHANGELOG.md * Rebuild lock files and fix ShopperLogin mutation test * Revert "Rebuild lock files and fix ShopperLogin mutation test" This reverts commit d9cfe50. * Add additional properties to ShopperLogin test types (#1185) * [V2] Re-generate lock files and fix hook lib tests (#1186) * re-generate lock files and fix test * Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/index.test.ts * Rebuild lockfiles using node 14 npm 8 * Revert "Rebuild lockfiles using node 14 npm 8" This reverts commit 3d5c0cb. * Use pwa-kit-dev for lint and format * Revert "Use pwa-kit-dev for lint and format" This reverts commit f46d83e. * Add typescript to internal-lib-build and rebuild lock files --------- Co-authored-by: vcua-mobify <[email protected]> Co-authored-by: vcua-mobify <[email protected]> * [V2] Internal lib build typescript dev dependency (#1194) * Move typescript to dev and peer dependency * Update package lock file * Lockfile updates --------- Co-authored-by: Ben Chypak <[email protected]> Co-authored-by: Adam Raya <[email protected]> Co-authored-by: Vincent Marta <[email protected]> Co-authored-by: Oliver Brook <[email protected]> Co-authored-by: echessman <[email protected]> Co-authored-by: John Boxall <[email protected]> Co-authored-by: Richard Sexton <[email protected]> Co-authored-by: Will Harney <[email protected]> Co-authored-by: Kevin He <[email protected]> Co-authored-by: Alex Vuong <[email protected]> Co-authored-by: Brad Adams <[email protected]> Co-authored-by: Charles Lavery <[email protected]> Co-authored-by: Adam Raya Navarro <[email protected]> Co-authored-by: ecRobertEngel <[email protected]> Co-authored-by: Sandra Golden <[email protected]> Co-authored-by: Jainam Sheth <[email protected]> Co-authored-by: mdenchev-aiopsgroup <[email protected]>

Initial commit

00c402a

bendvc commented Mar 20, 2023

View reviewed changes

bendvc marked this pull request as ready for review March 20, 2023 23:28

bendvc requested a review from a team as a code owner March 20, 2023 23:28

bendvc requested review from kevinxh and wjhsf March 20, 2023 23:29

bendvc added the ready for review PR is ready to be reviewed label Mar 20, 2023

wjhsf suggested changes Mar 21, 2023

View reviewed changes

bendvc and others added 17 commits March 21, 2023 09:10

Update packages/commerce-sdk-react/src/hooks/useAuthHelper.ts

97b0190

Co-authored-by: Will Harney <[email protected]>

Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts

20dfc21

Co-authored-by: Will Harney <[email protected]>

Update packages/commerce-sdk-react/src/hooks/ShopperOrders/cache.ts

5dc64b5

Co-authored-by: Will Harney <[email protected]>

Added root to all query keys, use remove over clear

b3a55a8

Merge branch 'add-cache-update-logic' of https://github.com/Salesforc…

c85a14a

…eCommerceCloud/pwa-kit into add-cache-update-logic

Remove previous impemented "clear" from utils

3d9002e

Initial tests for shoppercontexts

47df510

Update ShopperLogin tests

97359e3

Fix order tests

d04745b

Update packages/commerce-sdk-react/src/hooks/ShopperContexts/cache.ts

f20ef61

Co-authored-by: Will Harney <[email protected]>

Update cache.ts

522196f

Lint!

9a950fc

Merge branch 'develop' into add-cache-update-logic

e7bd07c

Update Json.tsx

a4b9191

Merge branch 'develop' into add-cache-update-logic

c685f96

Lint!

4b467a2

Testing race condition in tests

1e83f14

bendvc added 3 commits March 23, 2023 15:24

Re-add tests in other order.

5835c4d

Merge branch 'develop' into add-cache-update-logic

d378615

Update CHANGELOG.md

d15b5de

wjhsf approved these changes Mar 24, 2023

View reviewed changes

adamraya reviewed Mar 24, 2023

View reviewed changes

bendvc and others added 4 commits March 24, 2023 13:45

Add todo to complete context cache work

42c1fe1

Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/mutation.…

d146e2f

…test.ts Co-authored-by: Will Harney <[email protected]>

Update packages/commerce-sdk-react/src/components/ShopperExperience/P…

2f6f01a

…age/index.tsx Co-authored-by: Will Harney <[email protected]>

Merge branch 'add-cache-update-logic' of https://github.com/Salesforc…

0d2b555

…eCommerceCloud/pwa-kit into add-cache-update-logic

adamraya reviewed Mar 24, 2023

View reviewed changes

packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts Outdated Show resolved Hide resolved

bendvc and others added 2 commits March 24, 2023 14:57

Update useAuthHelper.ts

e4ec495

Update packages/commerce-sdk-react/src/hooks/ShopperCustomers/cache.ts

2229c09

Co-authored-by: Adam Raya <[email protected]>

bendvc removed the request for review from kevinxh March 24, 2023 22:27

bendvc added this pull request to the merge queue Mar 24, 2023

Merged via the queue into develop with commit fb15f77 Mar 24, 2023

vcua-mobify mentioned this pull request May 9, 2023

PWA Kit 2.7.1-alpha.0 release #1181

Merged

vcua-mobify mentioned this pull request May 11, 2023

[V2] PWA Kit Release 2.7.1 #1197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) #1073

Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) #1073

bendvc commented Mar 20, 2023 •

edited

Loading

bendvc Mar 20, 2023

bendvc Mar 20, 2023

vmarta Mar 21, 2023

kevinxh Mar 21, 2023

bendvc Mar 20, 2023

bendvc Mar 20, 2023

bendvc Mar 20, 2023

bendvc Mar 20, 2023

wjhsf Mar 21, 2023

wjhsf left a comment

wjhsf Mar 21, 2023

bendvc Mar 21, 2023

bendvc Mar 23, 2023

wjhsf Mar 21, 2023

bendvc Mar 21, 2023

kevinxh Mar 21, 2023 •

edited

Loading

wjhsf Mar 21, 2023

wjhsf Mar 21, 2023

wjhsf Mar 21, 2023

wjhsf Mar 23, 2023

bendvc Mar 24, 2023

adamraya Mar 24, 2023

bendvc Mar 24, 2023

		{queryHooks.map(({name, hook}) => {
		return renderQueryHook(name, {...hook})

Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) #1073

Implement Cache Logic for Shopper APIs (Contexts/Customers/Login/Orders) #1073

Conversation

bendvc commented Mar 20, 2023 • edited Loading

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wjhsf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinxh Mar 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bendvc commented Mar 20, 2023 •

edited

Loading

kevinxh Mar 21, 2023 •

edited

Loading