Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hooks] Fix the traversal of wishlist data #1045

Merged
merged 4 commits into from
Mar 8, 2023
Merged

[Hooks] Fix the traversal of wishlist data #1045

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5537578
Fix the traversal of wishlist data
vmarta Mar 8, 2023
e9d2e5f
Correct use of the fallback value
vmarta Mar 8, 2023
11a6947
Add todo
vmarta Mar 8, 2023
0ef7c22
Merge branch 'feature/integrate-commerce-sdk-react' into fix-wishlist…
vmarta Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/template-retail-react-app/app/hooks/use-wish-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const useWishList = ({listId = ''} = {}) => {
}
)
const wishLists = productLists?.data?.filter((list) => list.type === 'wish_list') || []
const currentWishlist = wishLists?.data?.find((list) => list.id === listId) || wishLists[0]
const currentWishlist = wishLists.find((list) => list.id === listId) || wishLists[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do we use wishLists[0] as a fallback, when we know that it doesn't have the correct ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, that's a good point.. we wanted to use the first wishlist only when the caller does not pass in the list id. Let me fix that.

Copy link
Collaborator

@kevinxh kevinxh Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, in the context of retail react app, you never need to pass in list id. The template always use the first wishlist that has type wish_list. We should remove that listId argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. We can either mimic the existing logic (of using a name and a type):

pwa-kit/packages/template-retail-react-app/app/hooks/use-wishlist.js

Lines 12 to 13 in 0ef7c22

const useWishlist = () =>
useCustomerProductList(PWA_DEFAULT_WISHLIST_NAME, PWA_DEFAULT_WISHLIST_TYPE)

Or use the "first wishlist that has type wish_list". Whichever we decide to do, let's do it in a separate PR.

return {
data: currentWishlist,
...restOfQuery
Expand Down