[Hooks] Fix the traversal of wishlist data #1045
Conversation
| @@ -31,7 +31,7 @@ export const useWishList = ({listId = ''} = {}) => { | |||
| } | |||
| ) | |||
| const wishLists = productLists?.data?.filter((list) => list.type === 'wish_list') || [] | |||
| const currentWishlist = wishLists?.data?.find((list) => list.id === listId) || wishLists[0] | |||
| const currentWishlist = wishLists.find((list) => list.id === listId) || wishLists[0] | |||
There was a problem hiding this comment.
We do we use wishLists[0] as a fallback, when we know that it doesn't have the correct ID?
There was a problem hiding this comment.
Ah right, that's a good point.. we wanted to use the first wishlist only when the caller does not pass in the list id. Let me fix that.
There was a problem hiding this comment.
TBH, in the context of retail react app, you never need to pass in list id. The template always use the first wishlist that has type wish_list. We should remove that listId argument.
There was a problem hiding this comment.
I see. We can either mimic the existing logic (of using a name and a type):
pwa-kit/packages/template-retail-react-app/app/hooks/use-wishlist.js
Lines 12 to 13 in 0ef7c22
Or use the "first wishlist that has type wish_list". Whichever we decide to do, let's do it in a separate PR.
A small bug fix, which is extracted from #1042.
FYI @alexvuong since you're working on wishlist-related stuffs too.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization