feat: Create stubs for public methods of inherited internal classes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 98.80% 98.82% +0.01%
==========================================
Files 25 25
Lines 2098 2120 +22
==========================================
+ Hits 2073 2095 +22
Misses 25 25 ☔ View full report in Codecov by Sentry. |
# Conflicts: # tests/safeds_stubgen/stubs_generator/test_generate_stubs.py
|
@lars-reimann Could you check these two PRs? |
|
Yep, tomorrow. Any preference which one to merge first? Or are they independent of each other? |
lars-reimann
changed the title
lars-reimann
requested changes
Mar 2, 2024
# Conflicts: # src/safeds_stubgen/stubs_generator/_generate_stubs.py # tests/safeds_stubgen/stubs_generator/test_generate_stubs.py
|
@lars-reimann Added all the changes, you can continue with the PR |
lars-reimann
requested changes
Mar 4, 2024
...__/test_generate_stubs/TestStubFileGeneration.test_stub_creation[inheritance_module].sdsstub
Outdated
Show resolved
Hide resolved
...__/test_generate_stubs/TestStubFileGeneration.test_stub_creation[inheritance_module].sdsstub
Outdated
Show resolved
Hide resolved
...__/test_generate_stubs/TestStubFileGeneration.test_stub_creation[inheritance_module].sdsstub
Outdated
Show resolved
Hide resolved
lars-reimann
pushed a commit
that referenced
this pull request
Mar 29, 2024
## [0.2.0](v0.1.0...v0.2.0) (2024-03-29) ### Features * Added generation for Safe-DS stubs files ([#33](#33)) ([ab45b45](ab45b45)) * Correct stubs for TypeVars ([#67](#67)) ([df8c5c9](df8c5c9)), closes [#63](#63) * Create stubs for public methods of inherited internal classes ([#69](#69)) ([71b38d7](71b38d7)), closes [#64](#64) * Rework import generation for stubs. ([#50](#50)) ([216e179](216e179)), closes [#38](#38) [#24](#24) [#38](#38) [#24](#24) * Safe-DS stubs also contain docstring information. ([#78](#78)) ([bdb43bd](bdb43bd)) * Stubs are created for referenced declarations in other packages ([#70](#70)) ([522f38d](522f38d)), closes [#66](#66) ### Bug Fixes * Some packages couldn't be analyzed ([#51](#51)) ([fa3d020](fa3d020)), closes [#48](#48) * Stub generation testing and fixing of miscellaneous bugs ([#76](#76)) ([97b0ab3](97b0ab3))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
Summary of Changes
Now stubs for public methods of internal classes that are being inherited will be created for the classes that inherit them.