Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stubs must be created for referenced declarations in other packages #66

Closed
Masara opened this issue Feb 24, 2024 · 1 comment · Fixed by #70
Closed

feat: Stubs must be created for referenced declarations in other packages #66

Masara opened this issue Feb 24, 2024 · 1 comment · Fixed by #70
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@Masara
Copy link
Contributor

Masara commented Feb 24, 2024 •
edited
Loading

Is your feature request related to a problem?

Currently, if a module imports classes from other packages stubs won't be created for those classes.

Say we are creating stubs for the package a and are currently working on a Python module with the following content:

from b import SomeClass

def f(p: SomeClass)

Then we also need to create some stub for the class SomeClass, or we can't use it. So limited stubs must be created for the declarations of other packages that package a depends on.

Desired solution

Create limited stubs for the imported classes from other packages, if they are imported.
@Masara Masara added the enhancement 💡 New feature or request label Feb 24, 2024
This was referenced Feb 24, 2024
Merged
Merged
@Masara Masara linked a pull request Feb 29, 2024 that will close this issue
feat: Stubs are created for referenced declarations in other packages #70
Merged
lars-reimann pushed a commit that referenced this issue Mar 3, 2024
@Masara @megalinter-bot
feat: Stubs are created for referenced declarations in other packages (…
522f38d 
…#70)

Closes #66

### Summary of Changes

Now limited stubs are created for imported classes from other packages.

---------

Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Analysis Mar 3, 2024
lars-reimann pushed a commit that referenced this issue Mar 29, 2024
@semantic-release-bot
chore(release): 0.2.0 [skip ci]
81b9b1d 
## [0.2.0](v0.1.0...v0.2.0) (2024-03-29)

### Features

* Added generation for Safe-DS stubs files ([#33](#33)) ([ab45b45](ab45b45))
* Correct stubs for TypeVars ([#67](#67)) ([df8c5c9](df8c5c9)), closes [#63](#63)
* Create stubs for public methods of inherited internal classes ([#69](#69)) ([71b38d7](71b38d7)), closes [#64](#64)
* Rework import generation for stubs. ([#50](#50)) ([216e179](216e179)), closes [#38](#38) [#24](#24) [#38](#38) [#24](#24)
* Safe-DS stubs also contain docstring information. ([#78](#78)) ([bdb43bd](bdb43bd))
* Stubs are created for referenced declarations in other packages ([#70](#70)) ([522f38d](522f38d)), closes [#66](#66)

### Bug Fixes

* Some packages couldn't be analyzed ([#51](#51)) ([fa3d020](fa3d020)), closes [#48](#48)
* Stub generation testing and fixing of miscellaneous bugs ([#76](#76)) ([97b0ab3](97b0ab3))
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library Analysis
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Stubs are created for referenced declarations in other packages Safe-DS/Stub-Generator
2 participants
@Masara @lars-reimann