feat: suggest adding assignment if statement does nothing #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 19231 19247 +16
Branches 4110 4117 +7
=========================================
+ Hits 19231 19247 +16 ☔ View full report in Codecov by Sentry. |
lars-reimann
deleted the
1142-in-warning-statement-does-nothing-suggest-adding-assignment
branch
lars-reimann
pushed a commit
that referenced
this pull request
May 9, 2024
## [0.15.0](v0.14.1...v0.15.0) (2024-05-09) ### Features * adjust type cast syntax and restore old precedence ([#1158](#1158)) ([07623fc](07623fc)), closes [#1150](#1150) * disable "unused" warning for placeholders whose name starts with an underscore ([#1155](#1155)) ([25781a8](25781a8)), closes [#1154](#1154) * give type casts the lowest precedence ([#1157](#1157)) ([7549fa1](7549fa1)), closes [#1150](#1150) * integrate version 0.24.0 of the `safe-ds` Python library ([#1162](#1162)) ([1a24a18](1a24a18)) * remove warning that package is empty ([#1159](#1159)) ([b13c5df](b13c5df)), closes [#1153](#1153) * suggest adding assignment if statement does nothing ([#1156](#1156)) ([11c81b3](11c81b3)), closes [#1142](#1142)
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1142
Summary of Changes
Suggest adding an assignment if the user likely forgot it.